From acfb155a85bfc186534045ae09d49e55ee94af8d Mon Sep 17 00:00:00 2001 From: Emmett Lalish Date: Tue, 9 Jan 2024 14:42:55 +1300 Subject: [PATCH] fixed reversal (#4624) --- packages/model-viewer/src/three-components/GroundedSkybox.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/model-viewer/src/three-components/GroundedSkybox.ts b/packages/model-viewer/src/three-components/GroundedSkybox.ts index b032cfdd5e..01cd2ef13e 100644 --- a/packages/model-viewer/src/three-components/GroundedSkybox.ts +++ b/packages/model-viewer/src/three-components/GroundedSkybox.ts @@ -13,7 +13,7 @@ * limitations under the License. */ -import {BackSide, BufferAttribute, Mesh, MeshBasicMaterial, SphereGeometry, Texture, Vector3} from 'three'; +import {BufferAttribute, Mesh, MeshBasicMaterial, SphereGeometry, Texture, Vector3} from 'three'; export class GroundedSkybox extends Mesh { private height = 0; @@ -21,7 +21,7 @@ export class GroundedSkybox extends Mesh { private resolution = 0; constructor() { - super(undefined, new MeshBasicMaterial({side: BackSide})); + super(undefined, new MeshBasicMaterial({depthWrite: false})); this.userData.noHit = true; } @@ -54,6 +54,7 @@ export class GroundedSkybox extends Mesh { function makeGeometry(height: number, radius: number, resolution: number) { const geometry = new SphereGeometry(radius, 2 * resolution, resolution); + geometry.scale(1, 1, -1); const pos = geometry.getAttribute('position') as BufferAttribute; const tmp = new Vector3();