Skip to content
This repository has been archived by the owner on Aug 29, 2024. It is now read-only.

cancel out subtraction with same term better #221

Open
evykassirer opened this issue Sep 10, 2017 · 4 comments
Open

cancel out subtraction with same term better #221

evykassirer opened this issue Sep 10, 2017 · 4 comments

Comments

@evykassirer
Copy link
Contributor

evykassirer commented Sep 10, 2017

for collect and combine like terms, addition, you'd see steps like this right now

y + 2x - 2x
y + (2-2)x
y + 0x
y + 0
y

it should instead just do

y + 2x - 2x
(maybe y + 0?)
y

you see this a lot in equation solving code, not totally sure the best place to fix it but opening an issue cause it's really not great pedagogically haha

@evykassirer evykassirer changed the title cancel out subtraction better cancel out subtraction with same term better Sep 10, 2017
@psmyth
Copy link

psmyth commented Oct 12, 2017

Hi, I'm interested in working on this.

@evykassirer
Copy link
Contributor Author

evykassirer commented Oct 13, 2017

yay! thanks for your interest 🎉 this is now assigned to you :)

I think before we get started it'd be good to have an idea of exactly what we'll change. Did you want to explore that yourself, have a conversation about it, or would you prefer if I made a call and you did the coding changes?

@psmyth
Copy link

psmyth commented Oct 13, 2017

I think you should make the call on how you want to handle it. I think the steps you laid out above are a good model.

@evykassirer
Copy link
Contributor Author

Cool - let's start with the case where 2x - 2x goes to 0 immediately instead of (2-2)x

Later if we can find a clean way of not having the 0 there at all (but only when it's part of a bigger sum) that'd be ✨

If you'd like assistance in finding the relevant area of the codebase to change and how to go about making the change let me know! Thanks for taking this on, it'll be much better :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants