Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Viewfinder API 24 and below (Only affects 9:16 aspect) #207

Open
Sk8aaron opened this issue May 22, 2024 · 2 comments
Open

Small Viewfinder API 24 and below (Only affects 9:16 aspect) #207

Sk8aaron opened this issue May 22, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Sk8aaron
Copy link

Sk8aaron commented May 22, 2024

JCA version:
1.0.0

Device:
physical LG-M153 API 23,
emulator original Pixel API 24,
emulator Pixel 7 Pro API 24,

Steps to reproduce:
run app on device with API 24 or below and make sure 9:16 aspect ratio is selected.

Expected:
viewfinder fits screen and has black bars where necessary

Observed:
viewfinder size is very small and has over-sized black bars on bottom and right side

Remarks
tested on API 21-35 with different resolutions this seems to only affect API 24 and below with 9:16 aspect.

emulator Pixel 7 Pro API 24
pixel7pro-API-24

emulator Pixel API 24
pixel-API-24

physical LG Fortune(M-153) API 23
9-16

@Sk8aaron Sk8aaron changed the title Small Viewfinder API 24 and below Small Viewfinder API 24 and below (Only affects 9:16 aspect) May 22, 2024
@yasith yasith self-assigned this May 24, 2024
@yasith
Copy link
Member

yasith commented May 24, 2024

@Sk8aaron We currently have an issue with rendering SurfaceView backed Viewfinder in API <= 24. Until the issue is fixed there. I've changed it so this app will use the EMBEDDED implementation mode (TextureView backed)

@temcguir temcguir added the bug Something isn't working label Jun 6, 2024
@MHKalantarian
Copy link

MHKalantarian commented Jul 30, 2024

I have found a workaround to fix this:

Use this version
cameraViewfinderCompose = "1.0.0-SNAPSHOT"

From this repository

maven {
                setUrl("https://androidx.dev/snapshots/builds/11723120/artifacts/repository")
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants