Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve external storage handling for external intent Image Capture #157

Open
JolandaVerhoef opened this issue Mar 29, 2024 · 3 comments
Open
Assignees
Labels
good first issue Good for newcomers

Comments

@JolandaVerhoef
Copy link
Collaborator

AndroidManifest.xml gives a lint warning for this code:

    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />

The warning is:

... is deprecated (and is not granted) when targeting Android 13+. If you need to query or interact 
with MediaStore or media files on the shared storage, you should instead use one or more new 
storage permissions: READ_MEDIA_IMAGES, READ_MEDIA_VIDEO or READ_MEDIA_AUDIO. 
@JolandaVerhoef JolandaVerhoef added the good first issue Good for newcomers label Mar 29, 2024
@Anshu-Bijarnia
Copy link

Hi, I can try to fix this issue. Can you assign me this issue ?

@temcguir
Copy link
Collaborator

Oops I just changed this code in #154 , but please take a look to see if there are any improvements that could be made. There were a lot of changes made around this permission and scoped storage between APIs 28-30, so it may be worth testing on emulators running on 27-31 to see if it is working correctly to take pictures / videos.

We can discuss on this issue if you have any questions.

@Anshu-Bijarnia
Copy link

I think a better approach would be permissions based on android version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants