Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Math.IEEEremainder #142

Open
dasa opened this issue Apr 8, 2022 · 1 comment
Open

Add support for Math.IEEEremainder #142

dasa opened this issue Apr 8, 2022 · 1 comment

Comments

@dasa
Copy link
Contributor

dasa commented Apr 8, 2022

Is your feature request related to a problem? Please describe.

Math.IEEEremainder isn't implemented and is commented as such at: https://github.com/google/j2cl/blob/master/jre/java/java/lang/Math.java#L34

Describe the solution you'd like

Add support for Math.IEEEremainder

Describe alternatives you've considered

I attempted an implementation based on this doc:

	static private double IEEEremainder(double dividend, double divisor) {
		return dividend - (divisor * Math.round(dividend / divisor));
	}

Additional context

The link above shows expected output, and there are tests for the Kotlin implementation.

@gkdn
Copy link
Member

gkdn commented Apr 8, 2022

Thanks for the detailed report. Would you like to send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants