-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReduceMin/Max operators return incorrect results with infinite values for HWY_EMU128 target #2434
Comments
Absolutely! Thanks for pointing that out, fixing coming shortly. |
copybara-service bot
pushed a commit
that referenced
this issue
Jan 9, 2025
…2434 PiperOrigin-RevId: 713663844
copybara-service bot
pushed a commit
that referenced
this issue
Jan 9, 2025
…2434 PiperOrigin-RevId: 713663844
copybara-service bot
pushed a commit
that referenced
this issue
Jan 9, 2025
…2434 PiperOrigin-RevId: 713663844
copybara-service bot
pushed a commit
that referenced
this issue
Jan 9, 2025
…2434 PiperOrigin-RevId: 713663844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I've noticed an issue with the
ReduceMin
operator when the input vector contains infinity values for theHWY_EMU128
target.The issue seems to be caused by the following line of code:
highway/hwy/ops/emu128-inl.h
Line 2921 in fecd465
as well as
highway/hwy/ops/emu128-inl.h
Line 2929 in fecd465
Instead of using HighestValue/LowestValue, would it be more appropriate to initialize with
+/-inf
?The text was updated successfully, but these errors were encountered: