Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReduceMin/Max operators return incorrect results with infinite values for HWY_EMU128 target #2434

Open
yohanchatelain opened this issue Jan 9, 2025 · 1 comment · May be fixed by #2437
Open

Comments

@yohanchatelain
Copy link

Hello,

I've noticed an issue with the ReduceMin operator when the input vector contains infinity values for the HWY_EMU128 target.

The issue seems to be caused by the following line of code:

T min = HighestValue<T>();

as well as

T max = LowestValue<T>();

Instead of using HighestValue/LowestValue, would it be more appropriate to initialize with +/-inf?

@jan-wassenberg
Copy link
Member

Absolutely! Thanks for pointing that out, fixing coming shortly.

copybara-service bot pushed a commit that referenced this issue Jan 9, 2025
copybara-service bot pushed a commit that referenced this issue Jan 9, 2025
copybara-service bot pushed a commit that referenced this issue Jan 9, 2025
copybara-service bot pushed a commit that referenced this issue Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants