Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the names of files under docs/analog/model_parameters/LV/tables_clear #42

Open
mithro opened this issue Aug 2, 2022 · 2 comments · May be fixed by #51
Open

Update the names of files under docs/analog/model_parameters/LV/tables_clear #42

mithro opened this issue Aug 2, 2022 · 2 comments · May be fixed by #51
Assignees
@mohanad0mohamed

Comments

@mithro
Copy link
Contributor

mithro commented Aug 2, 2022

The names of the files under docs/analog/model_parameters/LV/tables_clear should probably match primitive naming?

It might actually just be that the formatting of these file names need to match the other ones in this file? The files which made me think where the following;

  • docs/analog/model_parameters/LV/tables_clear/19_mos_3p3.csv
  • docs/analog/model_parameters/LV/tables_clear/21_mos_6p0.csv
  • docs/analog/model_parameters/LV/tables_clear/22_mos_6p0_1.csv
  • docs/analog/model_parameters/LV/tables_clear/21_mos_6p0_2.csv
@mithro
Copy link
Contributor Author

mithro commented Aug 2, 2022

I think they might just be _MOS_ or _Mos_ -- _Mos_ doesn't look right, so I'm guessing it _MOS_ is right?

@mohanad0mohamed mohanad0mohamed moved this to 📋 Backlog in GF180MCU PDK Backlog Aug 3, 2022
@mohanad0mohamed mohanad0mohamed self-assigned this Aug 4, 2022
@mohanad0mohamed
Copy link
Contributor

Should we stick to the naming convetion of nfet/pfet instead?
I'm suggesting 19_mos_3p3.csv to be 19_nfet_pfet_03v3.csv

@mohanad0mohamed mohanad0mohamed linked a pull request Aug 4, 2022 that will close this issue
Open
1 task
@mohanad0mohamed mohanad0mohamed moved this from 📋 Backlog to 👀 In review in GF180MCU PDK Backlog Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohanad0mohamed mohanad0mohamed

Labels
None yet
Projects
GF180MCU PDK Backlog
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the names of files under docs/analog/model_parameters/LV/tables_clear mabrains/gf180mcu-pdk
2 participants
@mithro @mohanad0mohamed