Memory saving loading weight for non-quant models #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@pengchongjin @michaelmoynihan Any idea on this PR? |
|
Thanks, @KaneGreen ! Coould you please sign the CLA in order to pass the pre-check? |
|
@pengchongjin I've signed that. But it doesn't update. Any way to re-run this check? |
|
@pengchongjin CLA has been signed |
This reverts commit 7a0fde1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #51
And this also increase the speed of loading weights. (in my computer, about 1min vs 2min)
Tested on
1.1-7b-itand7b-itmodel.but:
quantmodel.requires_gradofnn.ParameterinLinearandEmbeddingtoTrueafter the loading is completed. (I don't know why some nn.Parameters in model.py haverequires_gradas False and others as default True) But I think, this shouldn't affect sinceforwardfunction ofGemmaForCausalLMhas@torch.no_grad().