diff --git a/review/developer/handling-comments.md b/review/developer/handling-comments.md index cb43fb98..7df7d590 100644 --- a/review/developer/handling-comments.md +++ b/review/developer/handling-comments.md @@ -64,11 +64,11 @@ If you can't answer that question, ask the reviewer for clarification. And then, if you understand the comments but disagree with them, it's important to think collaboratively, not combatively or defensively: -```txt {.bad} +``` {.bad} Bad: "No, I'm not going to do that." ``` -```txt {.good} +``` {.good} Good: "I went with X because of [these pros/cons] with [these tradeoffs] My understanding is that using Y would be worse because of [these reasons]. Are you suggesting that Y better serves the original tradeoffs, that we should diff --git a/review/developer/small-cls.md b/review/developer/small-cls.md index 0501c550..8b5adc53 100644 --- a/review/developer/small-cls.md +++ b/review/developer/small-cls.md @@ -164,6 +164,7 @@ To take this a step further, you could combine these approaches and chart out an implementation plan like this, where each cell is its own standalone CL. Starting from the model (at the bottom) and working up to the client: +``` | Layer | Feature: Multiplication | Feature: Division | | ------- | ------------------------- | ------------------------------- | | Client | Add button | Add button | @@ -171,6 +172,7 @@ Starting from the model (at the bottom) and working up to the client: | Service | Implement transformations | Share transformation logic with | : : : multiplication : | Model | Add proto definition | Add proto definition | +``` ## Separate Out Refactorings {#refactoring}