From 27b793b5099a8c1d24345359b94f2414e1f4816f Mon Sep 17 00:00:00 2001 From: Marcin Owsiany Date: Tue, 14 Nov 2023 08:40:25 +0100 Subject: [PATCH 1/2] Change "parallel" to "concurrent" The sort of effects mentioned in the paragraph do not require a truly parallel execution. They can also happen in many concurrent execution cases too. --- review/reviewer/looking-for.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/review/reviewer/looking-for.md b/review/reviewer/looking-for.md index c27e26ed..0030415e 100644 --- a/review/reviewer/looking-for.md +++ b/review/reviewer/looking-for.md @@ -34,7 +34,7 @@ give you a demo of the functionality if it's too inconvenient to patch in the CL and try it yourself. Another time when it's particularly important to think about functionality -during a code review is if there is some sort of **parallel programming** going +during a code review is if there is some sort of **concurrent programming** going on in the CL that could theoretically cause deadlocks or race conditions. These sorts of issues are very hard to detect by just running the code and usually need somebody (both the developer and the reviewer) to think through them From d07152c6f81a3677fb3b7e2e0f1f27e5bee2bb4c Mon Sep 17 00:00:00 2001 From: Marcin Owsiany Date: Tue, 14 Nov 2023 08:49:16 +0100 Subject: [PATCH 2/2] Change another occurrence of "parallel" --- review/reviewer/looking-for.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/review/reviewer/looking-for.md b/review/reviewer/looking-for.md index 0030415e..38b1ee0f 100644 --- a/review/reviewer/looking-for.md +++ b/review/reviewer/looking-for.md @@ -222,7 +222,7 @@ In doing a code review, you should make sure that: - The code is well-designed. - The functionality is good for the users of the code. - Any UI changes are sensible and look good. -- Any parallel programming is done safely. +- Any concurrent programming is done safely. - The code isn't more complex than it needs to be. - The developer isn't implementing things they *might* need in the future but don't know they need now.