Github enterprise support

[nick-kanakis]

Are there plans to support github enterprise as well? I see that there are many github.com related functionality it would be nice if users could customize the endpoint to also support github enterprise.

[mikelalcon]

Hi Nicolas,

We wouldn't mind supporting GH enterprise. The main two problems is that we don't have the bandwidth right now and we don't have access to an example enterprise host to test it. But we would happily accept contributions. I think the main work is to extract all the hardcoded "https://github.com/" and make it a parameter for origin/destination (something like a param like enterprise = "https://example.com" or similar)

[nick-kanakis]

Nice, I can take up the task for that, I'm not sure about my bandwidth for this week but hopefully next week I can start.

[hsudhof]

This is going to be a bit of a pain, presumably the patterns should be replaced with a parser that is able to deal with the enterprise syntax, if possible. Otherwise, the util might need to be injected from the GitHubOption instead and rely less on statics.

…

On Thu, Oct 1, 2020 at 4:16 PM Nikolaos Kanakis ***@***.***> wrote: @mikelalcon <https://github.com/mikelalcon> I have started working on a version that supports GitHub enterprise. I'm unsure, what is the best way to deal with static variables at GithubUtil <https://github.com/google/copybara/blob/master/java/com/google/copybara/git/github/util/GitHubUtil.java#L35> . — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#134 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFKR2H5JBXMF4Q4F4UHVUUTSITPTNANCNFSM4REOSZWA> .

-- Henry Sudhof | Software Engineer | [email protected] | US-NYC-9TH 14E220

[nick-kanakis]

(hmm somehow I deleted my questions). Since the enterprise host syntax might differ quite a lot, I think I have to utilize GitHubOption but there are quite a few places that do not use it I will try to come up with a PoC and get your opinions.

[mikelalcon]

I think it cannot be in GHOptions, since it would apply globally.

For example, a common use case could be GH entrerprise <-> public GH

Another (not sure how common) GH enterprise 1 <-> GH enterprise 2.

If I have some spare cycles this/next week I can look into it. It might need some real GH enterprise iterations tests :)

[mikelalcon]

We can try to use GH PR instead of our internal Gerrit so that we can collaborate. sg?

[mikelalcon]

Nikolaos, Could you send us example GitHub Enterprise urls? (you can anonymize them) In particular https://foo type, "[email protected]:" ones, etc. Also if it can be installed in a path (https://foo.com/some_path/user/project)

…

On Fri, Oct 2, 2020 at 3:56 AM Nikolaos Kanakis ***@***.***> wrote: (hmm somehow I deleted my questions). Since the enterprise host syntax might differ quite a lot, I think I have to utilize GitHubOption but there are quite a few places that do not use it I will try to come up with a PoC and get your opinions. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#134 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHJWQDV32LN4WX6GJBQVLLSIWBTLANCNFSM4REOSZWA> .

[nick-kanakis]

Hi @mikelalcon sorry for the late reply:

• https://github.foo.bar.sampleCorp.com
• [email protected]
• https://github.foo.bar.sampleCorp.com/api/v3 (API calls)
• https://github.foo.bar.sampleCorp.com/user/copybara/

[mikelalcon]

Thanks! just to confirm, never installed under a path, right. Something like https://foo.bar.sampleCorp.com/github

[nick-kanakis]

No not in the cases I have seen

[mikelalcon]

K, after 6d33db4 it should be much easier. We can add a parameter to each fo the git.* that we want to use like

enterprise_host = "github.example.com"

[mikelalcon]

Assigned to you if you want to tackle this, otherwise I can see if I can do it in the next weeks :)

[ljharb]

any update?

[nick-kanakis]

Sorry couldn't find time to work on it. Feel free to pick it up

[rubenLindstrom]

Also interested!

[andrew-kowalczyk-cb]

@mikelalcon @nick-kanakis

it's been a while since the last comments, but did want to provide an update of mine!

I ended up forking this repo and getting a proof of concept working with GitHub Enterprise, here's the list of files that I needed to change the hardcoded github.com/api.github.com URLs to the matching GitHub Enterprise URLs:

java/com/google/copybara/git/GitHubPrDestination.java
java/com/google/copybara/git/GitHubWriteHook.java
java/com/google/copybara/git/GitRepoType.java
java/com/google/copybara/git/github/api/GitHubApiTransportImpl.java
java/com/google/copybara/git/github/util/GitHubHost.java

there's definitely way more work to get this properly working from a configuration level, but did want to report here that I was able to sync code and pull requests!

[castler]

@mikelalcon

In #319 I was able to introduce GitHub enterprise support.

All tests passed on my side (CI, let's see).

Due to the need to inject the GitHub host into various places it touches a lot of places.

I am happy to address any review comments

[junlong-gao]

@mikelalcon

In #319 I was able to introduce GitHub enterprise support.

All tests passed on my side (CI, let's see).

Due to the need to inject the GitHub host into various places it touches a lot of places.

I am happy to address any review comments

Thanks! We are also blocked by this, is there anything pending before merging?