Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dependencies differently, so that Dependabot "sees" them (and "group" dependencies which Dependabot already sees) #2302

Closed
vorburger opened this issue Oct 25, 2023 · 5 comments
Assignees
Labels
dependencies Pull requests that update a dependency file effort:medium Medium effort - 3 to 5 days P1 High priority issue type:build Issues related to code build type:code health type:process Create or improve processes type:testing Improvements on tests or testing infrastructure

Comments

@vorburger
Copy link
Member

vorburger commented Oct 25, 2023

The goal of this issue is to improve how this project declares its dependencies in Gradle.

The primary motivation for this issue is that the Dependabot which I activated in #2195 so far only raises a limited number of "version bump PRs", because as-is Dependabot only sees Gradle plugins, and the few Jackson dependencies declared in settings.gradle.kts and in common/build.gradle.kts and buildSrc/build.gradle.kts, as well as GitHub Actions - but it misses all the (more interesting) dependencies in buildSrc/src/main/kotlin/Dependencies.kt (understandably, because that's "non-standard / custom Kt Gradle code").

As a "side effect" of this work, I'm also hoping to be able to better declaratively define "groups" of dependencies which "belong together", so that Dependabot automatically (instead of me manually) raises #2301 instead of its individual (and incomplete) #2283 and #2285.

@vorburger vorburger added type:testing Improvements on tests or testing infrastructure P1 High priority issue type:code health type:process Create or improve processes effort:medium Medium effort - 3 to 5 days type:build Issues related to code build dependencies Pull requests that update a dependency file labels Oct 25, 2023
@vorburger vorburger self-assigned this Oct 25, 2023
@vorburger
Copy link
Member Author

@vorburger
Copy link
Member Author

@vorburger
Copy link
Member Author

With #2306 merged, the next step here (from my side) is to wait and see if Dependabot will automagically propose a bump for Glide...

@vorburger
Copy link
Member Author

wait and see if Dependabot will automagically propose a bump for Glide...

Reminder to myself, I forgot about this: Because of how https://github.com/google/android-fhir/blob/master/.github/dependabot.yaml is currently configured, any #2306-like work will only lead to new dependency update PRs at interval: weekly on day: monday... should we make it more frequent?

@vorburger
Copy link
Member Author

With #2306 merged, the next step here (from my side) is to wait and see if Dependabot will automagically propose a bump for Glide...

It see, see #2325.

Reminder to myself, I forgot about this: Because of how https://github.com/google/android-fhir/blob/master/.github/dependabot.yaml is currently configured, any #2306 work will only lead to new dependency update PRs at interval: weekly on day: monday... should we make it more frequent?

Let's keep it weekly.

#2591 will shortly move all remaining dependencies from Dependencies.kt into that libs.versions.toml.

Closing as Done!

@github-project-automation github-project-automation bot moved this from New to Complete in Android FHIR SDK Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file effort:medium Medium effort - 3 to 5 days P1 High priority issue type:build Issues related to code build type:code health type:process Create or improve processes type:testing Improvements on tests or testing infrastructure
Projects
Status: Complete
Development

No branches or pull requests

1 participant