Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel/Blaze BUILD #72

Open
cpsauer opened this issue Mar 13, 2022 · 5 comments
Open

Bazel/Blaze BUILD #72

cpsauer opened this issue Mar 13, 2022 · 5 comments

Comments

@cpsauer
Copy link

cpsauer commented Mar 13, 2022

Hey Googlers!

Any chance you'd be down to release the Blaze/Bazel (Blazel!) BUILD files for this code? Would be handy to those of us building with Bazel, and I assume you've got them internally already. I think the only external dep, PromisesObjC, already has released theirs, which should keep things pretty easy.

If useful, here's the start of one I spun up for the subspecs I needed:

# Created referencing https://github.com/google/GoogleUtilities/blob/406c461ae85acbc2da327f13619ffa187f7b729e/GoogleUtilities.podspec

objc_library(
    name = "Environment",
    hdrs = glob(["GoogleUtilities/Environment/Public/GoogleUtilities/*.h"]),
    includes = ["GoogleUtilities/Environment/Public"],
    visibility = ["//visibility:public"],

    srcs = glob(["GoogleUtilities/Environment/**/*.m", "GoogleUtilities/Environment/**/*.h"]),
    deps = ["@GooglePromises//:FBLPromises", ":IsAppEncrypted"],
    sdk_frameworks = ["Security"],
)

objc_library(
    name = "Logger",
    hdrs = glob(["GoogleUtilities/Logger/Public/GoogleUtilities/*.h"]),
    includes = ["GoogleUtilities/Logger/Public"],
    visibility = ["//visibility:public"],

    srcs = glob(["GoogleUtilities/Logger/**/*.m", "GoogleUtilities/Logger/**/*.h"]),
    deps = [":Environment"],
)

objc_library(
    name = "IsAppEncrypted",
    hdrs = ["third_party/IsAppEncrypted/Public/IsAppEncrypted.h"],
    srcs = ["third_party/IsAppEncrypted/IsAppEncrypted.m"],
)

Thanks for your consideration!
Chris
(ex-Googler)

@cpsauer cpsauer changed the title Bazel/Blaze Build File Bazel/Blaze BUILD Mar 13, 2022
@cpsauer
Copy link
Author

cpsauer commented Aug 8, 2023

Friendly bump! (Was brought back here by updating to match your changes to third_party).

@cpsauer
Copy link
Author

cpsauer commented Aug 8, 2023

Nick, I'm going to tag you, if that's ok, since it looks like you've been rolling out a bunch of great infra commits here @ncooke3

@ncooke3
Copy link
Member

ncooke3 commented Aug 11, 2023

Hi @cpsauer, we are willing to consider community support from a PR with an implementation that includes docs and GitHub Action tests. I think a simple workflow to perform build tests on the library targets would be sufficient.

@ncooke3
Copy link
Member

ncooke3 commented Aug 11, 2023

At a quick glance, your code above looks good. I'm not too familiar with bazel, but would be happy to answer questions where I can.

@cpsauer
Copy link
Author

cpsauer commented Aug 12, 2023

Hey, Nick! Thanks for taking the time to reply.
Are there not already BUILD files used internally for GoogleUtilities?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants