Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw Unit Y-Axis Assumes Square #339

Open
iroessle opened this issue Apr 14, 2022 · 0 comments
Open

Raw Unit Y-Axis Assumes Square #339

iroessle opened this issue Apr 14, 2022 · 0 comments

Comments

@iroessle
Copy link

In Features.py:

world_tl_to_feature_minimap = transform.Linear(
scale=raw_resolution / map_size.max_dim() if raw_resolution else None)

This only works correctly if the map is a square. Otherwise the dimension that is smaller than map_size.max_dim() gets improperly scaled down. The correct solution would be to scale each dimension of raw resolution by the commensurate max length of each map dimension.

-Ian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant