Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake.timeOfDay() #79

Open
serhalp opened this issue Jan 11, 2021 · 0 comments
Open

Add fake.timeOfDay() #79

serhalp opened this issue Jan 11, 2021 · 0 comments

Comments

@serhalp
Copy link
Contributor

serhalp commented Jan 11, 2021

We frequently need to generate a string representation of a time of day in Good Eggs code.

We have a documented standard for the format to use for manipulating and storing such a string: HH:mm. This is e.g. 14:00.

However, we also frequently have a need to generate user-facing time of day string representations, which would usually be a different format, such as 2pm, 2:00 pm, or 2:00:00 pm. Since we do not have a standard for such a format (appropriately so, I think – this is a design concern, and we have disparate types of audiences... customers, employees, engineers, etc.), it seems difficult to design a convenient, expressive method for this that would not introduce bugs.

I'm not sure on this one. I would propose we start with just adding fake.timeOfDay() which generates our standard documented HH:mm format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant