Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Recommended K8s Labels #44

Closed
alex-bezek opened this issue Sep 26, 2023 · 2 comments · Fixed by #45
Closed

Support Recommended K8s Labels #44

alex-bezek opened this issue Sep 26, 2023 · 2 comments · Fixed by #45

Comments

@alex-bezek
Copy link
Contributor

Currently, this helm chart uses the label app across resources such as here. This works great for the most part, except internally, we have tooling that relies on the Kubernetes recommended labels, specifically app.kubernetes.io/instance.

Would you be open to accepting a contribution that adds this label, or alternatively, add a helm value for passing additional common labels similar to how other helm charts work https://github.com/bitnami/charts/blob/main/bitnami/postgresql/values.yaml#L66

Thank you for the great app and chart, if you are open to either of these options, let me know and I can make a PR!

@DrPsychick
Copy link
Member

DrPsychick commented Sep 26, 2023

Hey @alex-bezek, that is an absolute reasonable request, thanks for taking the time to propose it.
Please do open a PR and I will review it as soon as I can. Going the route of many other charts seems very reasonable to me as well.

@alex-bezek
Copy link
Contributor Author

@DrPsychick I've opened a PR that adds in the new labels and allows users to pass in additional labels as well #45
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants