Adding ATHENS_STORAGE_TYPE as Env variable doesn't override the default disk

[salehparsa]

I've noticed that if you add ATHENS_STORAGE_TYPE as an ENV variable it will just cause having dupplicated ATHENS_STORAGE_TYPE and disk always stays. For instance the only way to configure S3 as a storage is adding following to the values:

storage:
  type: s3
  s3:
    region: "MY REGION"
    bucket: "MY BUCKET"
    useDefaultConfiguration: "true"

[DrPsychick]

Yes, that is right. While Athens itself is configured through ENV, the helm chart already takes care of quite a few of those variables.

ATHENS_STORAGE_TYPE is one of those variables, always set from values:

        - name: ATHENS_STORAGE_TYPE
          value: {{ .Values.storage.type | quote }}