Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback detection should work fine for multi-schema use case if one schema is a no-op and the other is rollback #272

Open
shantstepanian opened this issue May 26, 2020 · 0 comments

Comments

@shantstepanian
Copy link
Contributor

shantstepanian commented May 26, 2020

The Rollback detection logic (see DefaultRollbackDetector class) has a sanity check to verify that all schemas in a deployment have the same rollback behavior. i.e. if schemas are managed in the same way, then we shouldn't encounter a case where one schema is marked as rollback and the other isn't

However, we neglected the use case where one schema is marked as rollback and the other is not (e.g. if no changes occurred on that schema)

We should fix DefaultRollbackDetector to handle this logic, along with its unit test. Also worth trying this scenario out on RollbackScenarioTest to try out the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant