Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: Launch Package template triggered with no config does not match the templates in package.json #3457

Open
hyangah opened this issue Jul 17, 2024 · 0 comments
Labels
Debug Issues related to the debugging functionality of the extension.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Jul 17, 2024

In #3387, the "Launch Package" template in package.json was updated to use ${workspaceFolder}.
But we missed to update the template in

config: {
name: 'Launch Package',
type: this.defaultDebugAdapterType,
request: 'launch',
mode: 'auto',
program: '${fileDirname}'
}

that is referenced when launching debugging without launch.json for the first time.
I think the right fix is to make the goDebugConfiguration read the template in package.json
instead of maintaining the copy in the code, so we update only one place in the future.

@hyangah hyangah added the Debug Issues related to the debugging functionality of the extension. label Jul 17, 2024
@hyangah hyangah added this to the v0.43.0 milestone Jul 17, 2024
@hyangah hyangah changed the title debug: Launch Package template triggered debug: Launch Package template triggered with no config does not match the templates in package.json Jul 17, 2024
@hyangah hyangah modified the milestones: v0.43.0, v0.44.0 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debug Issues related to the debugging functionality of the extension.
Projects
None yet
Development

No branches or pull requests

1 participant