Skip to content

Commit 557f09f

Browse files
committed
.github/workflows: fix github CI long test
Fix typo. And, increase the vscgo installation timeout when running on windows. The default timeout 2s isn't long enough for `go install`. Change-Id: I2c6171af46bf69c81b8acad6269015247593954f Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/555616 Reviewed-by: Suzy Mueller <[email protected]> TryBot-Result: kokoro <[email protected]> Commit-Queue: Hyang-Ah Hana Kim <[email protected]>
1 parent 690cf2e commit 557f09f

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/test-long-all.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
- name: Install Go tools (Modules mode)
4949
run: |
5050
go version
51-
go run ./tools/installtools/main.Go
51+
go run ./tools/installtools/main.go
5252
working-directory: ./extension
5353
env:
5454
GO111MODULE: on

extension/src/goInstallTools.ts

+1
Original file line numberDiff line numberDiff line change
@@ -829,6 +829,7 @@ export async function installVSCGO(
829829
// build from source acquired from the module proxy if this is a non-preview version.
830830
try {
831831
const args = ['install', `${importPath}${version}`];
832+
console.log(`installing vscgo: ${args.join(' ')}`);
832833
await execFile(getBinPath('go'), args, { cwd, env });
833834
return progPath;
834835
} catch (e) {

extension/test/gopls/telemetry.test.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,10 @@ function testTelemetryPrompt(tc: testCase, wantPrompt: boolean) {
172172
};
173173
}
174174

175-
describe('# telemetry reporter using vscgo', async () => {
175+
describe('# telemetry reporter using vscgo', async function () {
176+
if (os.platform() === 'win32') {
177+
this.timeout(10000); // go install is slow on windows builder.
178+
}
176179
// installVSCGO expects
177180
// {extensionPath}/vscgo: vscgo source code for testing.
178181
// {extensionPath}/bin: where compiled vscgo will be stored.

0 commit comments

Comments
 (0)