Skip to content

Commit

Permalink
readme+welcome: announce remote attach debugging with dlv-dap
Browse files Browse the repository at this point in the history
Updates #1930
Updates #1861

Will add gophercon details separately.

Change-Id: I87fbe7dc3a41d0c9d3b27e40bd81b84a269a2ef9
GitHub-Last-Rev: 8a1b13f
GitHub-Pull-Request: #1943
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/371494
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Trust: Peter Weinberger <[email protected]>
TryBot-Result: kokoro <[email protected]>
  • Loading branch information
polinasok authored and hyangah committed Dec 14, 2021
1 parent 34504fd commit 15a266b
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 8 deletions.
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@
provides rich language support for the
[Go programming language](https://golang.org/).

📣
[Remote attach debugging](docs/debugging.md#connecting-to-headless-delve-with-target-specified-at-server-start-up) is now available via Delve's native DAP implementation with Delve v1.7.3 or newer.
We plan to enable this as the default in early 2022 to enhance remote debugging with the same
[debugging features](docs/debugging.md) that are already in use for local debugging.
We recommend switching your remote attach configurations in `launch.json` to use
`"debugAdapter":"dlv-dap"` now to verify that this works for you.
Please [file a new issue](https://github.com/golang/vscode-go/issues/new/choose) if you encounter any problems.

## Quick Start

Expand Down
4 changes: 2 additions & 2 deletions src/goMain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -724,10 +724,10 @@ If you would like additional configuration for diagnostics from gopls, please se
function showGoWelcomePage(ctx: vscode.ExtensionContext) {
// Update this list of versions when there is a new version where we want to
// show the welcome page on update.
const showVersions: string[] = ['0.27.0'];
const showVersions: string[] = ['0.30.0'];
// TODO(hyangah): use the content hash instead of hard-coded string.
// https://github.com/golang/vscode-go/issue/1179
let goExtensionVersion = '0.27.0';
let goExtensionVersion = '0.30.0';
let goExtensionVersionKey = 'go.extensionVersion';
if (isInPreviewMode()) {
goExtensionVersion = '0.0.0';
Expand Down
11 changes: 5 additions & 6 deletions src/welcome.ts
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,11 @@ export class WelcomePanel {
<div class="Announcement">
<img src="${announceURI}" alt="announce" class="Announcement-image" />
<p>
Heads up!
The extension now uses Delve's native DAP implementation (<a href="https://github.com/go-delve/delve/blob/master/Documentation/usage/dlv_dap.md">dlv-dap</a>)
for local debugging. We updated the <a href="https://github.com/golang/vscode-go/blob/master/docs/debugging.md">
Documentation for Debugging</a> to show the new features available with dlv-dap.
This change does not apply to remote debugging yet. For remote debugging, keep following
the instruction in the <a href="https://github.com/golang/vscode-go/blob/master/docs/debugging-legacy.md">old documentation</a>.
New! <a href="https://github.com/golang/vscode-go/blob/master/docs/debugging.md#remote-debugging">Remote
attach debugging</a> is now available on demand via Delve's native DAP implementation with Delve v1.7.3 or newer.
We plan to enable this as the default in early 2022 to enhance remote debugging with the same
<a href="https://github.com/golang/vscode-go/blob/master/docs/debugging.md">debugging features</a>
that are already in use for local debugging.
</p>
</div>
Expand Down

0 comments on commit 15a266b

Please sign in to comment.