go/analysis/analysistest: avoid nil panic from an invalid token.Pos

See failures in CL 638395
golang · Dec 22, 2024 · ee2e6da · ee2e6da
1 parent ebeac1b
commit ee2e6da
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/go/analysis/analysistest/analysistest.go b/go/analysis/analysistest/analysistest.go
@@ -193,9 +193,16 @@ func RunWithSuggestedFixes(t Testing, dir string, a *analysis.Analyzer, patterns
 					}
 					file, endfile := act.Package.Fset.File(start), act.Package.Fset.File(end)
 					if file == nil || endfile == nil || file != endfile {
+						fileName := func(p token.Pos) string {
+							file := act.Package.Fset.File(start)
+							if file != nil {
+								return file.Name()
+							}
+							return fmt.Sprintf("<invalid file pos: %v>", p)
+						}
 						t.Errorf(
 							"diagnostic for analysis %v contains Suggested Fix with malformed spanning files %v and %v",
-							act.Analyzer.Name, file.Name(), endfile.Name())
+							act.Analyzer.Name, fileName(start), fileName(end))
 						continue
 					}
 					if _, ok := fileContents[file]; !ok {