From 00b1eb006d55b229a2ee88d586ce675f87a3d7a4 Mon Sep 17 00:00:00 2001 From: Jonathan Amsterdam Date: Sun, 8 Dec 2024 17:44:37 -0500 Subject: [PATCH] tests/screentest: remove a test cases Commented out the multi-GOOS 540x1080 test. I tried and failed to increase its reliability. Running locally against staging, it still fails about 20% of the time, but always succeeds after a retry. Running on Cloud Build against staging, the failure rate seems higher, and retries don't help. More detail in a comment. Change-Id: I31e334d03c6bdff6733ed675a97677a723309ce0 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/634555 LUCI-TryBot-Result: Go LUCI kokoro-CI: kokoro Reviewed-by: Robert Findley --- tests/screentest/testcases.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/screentest/testcases.txt b/tests/screentest/testcases.txt index e4fbae15..0da16341 100644 --- a/tests/screentest/testcases.txt +++ b/tests/screentest/testcases.txt @@ -131,7 +131,12 @@ eval {{$hideElements}} eval {{$hideLinksHeading}} sleep 1s capture viewport -capture viewport 540x1080 +# This fails around 40% of the time with an 11-pixel difference. That is due to +# a slightly longer scrollbar. Changing "viewport" to "fullscreen" reveals that +# the real difference is the page length: there is extra blank space at the +# bottom of varying size. +# I have not been able to fix that or understand why it happens. +# capture viewport 540x1080 test retracted package path /k8s.io/client-go@v1.5.2