internal/worker: do not propagate CompareModule errors

An endpoint should return an error only when we think this error is transient, i.e., it might go away with a retry. Otherwise, a task can be retried indefinitely which might clog the queue. This is happening for compare mode. We log the error message for visibility but we do not propagate it back. Note that in govulncheck mode we save the error to the table, but this does not make sense for compare mode. Change-Id: I106d182406e12ffc17b84f9e98d60f3daa00f110 Reviewed-on: https://go-review.googlesource.com/c/pkgsite-metrics/+/543455 Reviewed-by: Jonathan Amsterdam <[email protected]> Run-TryBot: Zvonimir Pavlinovic <[email protected]> TryBot-Result: Gopher Robot <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
golang · Nov 20, 2023 · 4f71cc8 · 4f71cc8
1 parent 3379007
commit 4f71cc8
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/internal/worker/govulncheck_scan.go b/internal/worker/govulncheck_scan.go
@@ -269,7 +269,11 @@ func (s *scanner) CompareModule(ctx context.Context, w http.ResponseWriter, sreq
 		}
 		return nil
 	})
-	return err
+
+	if err != nil {
+		log.Errorf(ctx, err, "CompareModule failed for: %s", baseRow.ModulePath)
+	}
+	return nil
 }
 
 func createComparisonRow(pkg string, result *govulncheck.SandboxResponse, baseRow *govulncheck.Result, mode string) (row *govulncheck.Result) {