Improve mock usability in tests

feldentm-SAP · feldentm-SAP · commit d0755d374853 · 2022-10-21T09:07:50.000+02:00
Add stacktrace on fatal exit of mocked call to allow maintainers of tests using this API to understand what is actually going wrong
diff --git a/gomock/controller.go b/gomock/controller.go
@@ -190,7 +190,7 @@ func (ctrl *Controller) Call(receiver interface{}, method string, args ...interf
 			// and this line changes, i.e. this code is wrapped in another anonymous function.
 			// 0 is us, 1 is controller.Call(), 2 is the generated mock, and 3 is the user's test.
 			origin := callerInfo(3)
-			ctrl.T.Fatalf("Unexpected call to %T.%v(%v) at %s because: %s", receiver, method, args, origin, err)
+			ctrl.T.Fatalf("Unexpected call to %T.%v(%v) at %s because: %s\n  from %s", receiver, method, args, origin, err, debug.Stack())
 		}
 
 		// Two things happen here:

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ func (ctrl *Controller) Call(receiver interface{}, method string, args ...interf`
`190`	`190`	`// and this line changes, i.e. this code is wrapped in another anonymous function.`
`191`	`191`	`// 0 is us, 1 is controller.Call(), 2 is the generated mock, and 3 is the user's test.`
`192`	`192`	`origin := callerInfo(3)`
`193`		`- ctrl.T.Fatalf("Unexpected call to %T.%v(%v) at %s because: %s", receiver, method, args, origin, err)`
	`193`	`+ ctrl.T.Fatalf("Unexpected call to %T.%v(%v) at %s because: %s\n from %s", receiver, method, args, origin, err, debug.Stack())`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`// Two things happen here:`