x/tools/gopls: CodeAction: nil panic in findMatchingDiagnostics

[adonovan]

#!stacks
"sigpanic" && "findMatchingDiagnostics:+5"

Issue created by stacks.

func (s *server) findMatchingDiagnostics(uri protocol.DocumentURI, pd protocol.Diagnostic) []*cache.Diagnostic {
	s.diagnosticsMu.Lock()
	defer s.diagnosticsMu.Unlock()

	var sds []*cache.Diagnostic
	for _, viewDiags := range s.diagnostics[uri].byView {   // nil deref panic

This stack mX6OTg was reported by telemetry:

• crash/crash
• runtime.gopanic:+69
• runtime.panicmem:=262
• runtime.sigpanic:+19
• golang.org/x/tools/gopls/internal/server.(*server).findMatchingDiagnostics:+5
• golang.org/x/tools/gopls/internal/server.(*server).codeActionsMatchingDiagnostics:+21
• golang.org/x/tools/gopls/internal/server.(*server).CodeAction:+148
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+160
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
• golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
• golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
• runtime.goexit:+0

golang.org/x/tools/[email protected] go1.23.1 darwin/arm64 other (1)

[gabyhelp]

Related Issues

• x/tools/gopls: crash in Hover (telemetry) #69362
• x/tools/gopls: analysisinternal.ZeroValue crash on (presumably) unsafe.Pointer #70585 (closed)
• x/tools/gopls: Hover: panic in lookup{ObjectByName,DocLinkSymbol} #69616
• x/tools/gopls: OOB index crash in completion.expectedReturnStmtType #70636 (closed)
• x/tools/gopls: nil Signature (?) deref in Completion #70634 (closed)
• x/tools/gopls: completion: failed type assertion in inferExpectedTypeArg #70889 (closed)
• x/tools/gopls: automated issue report (crash) #66174 (closed)
• x/tools/gopls: Hover: nil deref in golang.StdSymbolOf #70969
• x/tools/gopls: panic in token.File.Name within PackageDocHTML (telemetry) #70149 (closed)
• x/tools/gopls: stubmethods: nil deref of FuncType.Results in fromReturnStmt #70967

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/639396 mentions this issue: gopls/internal/server: fix nil panic in findMatchingDiagnostics