With go 1.20 enters an infinite loop while trying to generate (a deterministic) ECDSA key

[yogeshbdeshpande]

Go version

go version go1.20.3 linux/amd64

Output of go env in your module/workspace:

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/yogdes01/.cache/go-build"
GOENV="/home/yogdes01/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/yogdes01/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/yogdes01/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.20"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.20/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20.3"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/yogdes01/veraison-ear/ear/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1650575872=/tmp/go-build -gno-record-gcc-switches"

What did you do?

ECDSA Key Generation Panics: i.e. ecdsa.GenerateKey() panics intermittently, when Randomness Source is all set to Zero.

Could it be because of:
https://go-review.googlesource.com/c/go/+/353849

What did you see happen?

Crash:

Full Trace see below:

go test -run TestAppraisalExtensions_SetGetKeyAttestation_ok --timeout 5s
panic: test timed out after 5s
running tests:
TestAppraisalExtensions_SetGetKeyAttestation_ok (5s)
goroutine 36 [running]:
testing.(*M).startAlarm.func1()
/usr/lib/go-1.20/src/testing/testing.go:2241 +0x3c5
created by time.goFunc
/usr/lib/go-1.20/src/time/sleep.go:176 +0x32
goroutine 1 [chan receive]:
testing.(*T).Run(0xc00013fa00, {0x8e0664?, 0x51caa5?}, 0x908118)
/usr/lib/go-1.20/src/testing/testing.go:1630 +0x405
testing.runTests.func1(0xc0adc0?)
/usr/lib/go-1.20/src/testing/testing.go:2036 +0x45
testing.tRunner(0xc00013fa00, 0xc000161c88)
/usr/lib/go-1.20/src/testing/testing.go:1576 +0x10b
testing.runTests(0xc000119220?, {0xc04200, 0x23, 0x23}, {0x20?, 0x100c000114d58?, 0xc0a3a0?})
/usr/lib/go-1.20/src/testing/testing.go:2034 +0x489
testing.(*M).Run(0xc000119220)
/usr/lib/go-1.20/src/testing/testing.go:1906 +0x63a
main.main()
_testmain.go:125 +0x1aa
goroutine 6 [select]:
[github.com/lestrrat-go/httprc.runFetchWorker({0x979f48](http://github.com/lestrrat-go/httprc.runFetchWorker(%7B0x979f48), 0xc000028078}, 0xc00007e540, {0x0, 0x0})
/home/yogdes01/go/pkg/mod/github.com/lestrrat-go/httprc@v1.0.4/fetcher.go:135 +0xd3
created by github.com/lestrrat-go/httprc.NewFetcher
/home/yogdes01/go/pkg/mod/github.com/lestrrat-go/httprc@v1.0.4/fetcher.go:75 +0x1ce
goroutine 7 [select]:
[github.com/lestrrat-go/httprc.runFetchWorker({0x979f48](http://github.com/lestrrat-go/httprc.runFetchWorker(%7B0x979f48), 0xc000028078}, 0xc00007e540, {0x0, 0x0})
/home/yogdes01/go/pkg/mod/github.com/lestrrat-go/httprc@v1.0.4/fetcher.go:135 +0xd3
created by github.com/lestrrat-go/httprc.NewFetcher
/home/yogdes01/go/pkg/mod/github.com/lestrrat-go/httprc@v1.0.4/fetcher.go:75 +0x1ce
goroutine 8 [select]:
[github.com/lestrrat-go/httprc.runFetchWorker({0x979f48](http://github.com/lestrrat-go/httprc.runFetchWorker(%7B0x979f48), 0xc000028078}, 0xc00007e540, {0x0, 0x0})
/home/yogdes01/go/pkg/mod/github.com/lestrrat-go/httprc@v1.0.4/fetcher.go:135 +0xd3
created by github.com/lestrrat-go/httprc.NewFetcher
/home/yogdes01/go/pkg/mod/github.com/lestrrat-go/httprc@v1.0.4/fetcher.go:75 +0x1ce
goroutine 9 [runnable]:
io.ReadAtLeast({0x9768c0, 0xc396a0}, {0xc000194280, 0x20, 0x20}, 0x20)
/usr/lib/go-1.20/src/io/io.go:326 +0x19c
io.ReadFull(...)
/usr/lib/go-1.20/src/io/io.go:351
crypto/ecdsa.randomPoint[...](0xc000024e40, {0x9768c0, 0xc396a0})
/usr/lib/go-1.20/src/crypto/ecdsa/ecdsa.go:202 +0xf2
crypto/ecdsa.generateNISTEC[...](0xc000024e40, {0x9768c0, 0xc396a0?})
/usr/lib/go-1.20/src/crypto/ecdsa/ecdsa.go:181 +0x37
crypto/ecdsa.GenerateKey({0x97a988, 0xbfb9c0}, {0x9768c0, 0xc396a0})
/usr/lib/go-1.20/src/crypto/ecdsa/ecdsa.go:170 +0x1c6
github.com/veraison/ear.TestAppraisalExtensions_SetGetKeyAttestation_ok(0x0?)
/home/yogdes01/veraison-ear/ear/ear_appraisal_test.go:22 +0x10c
testing.tRunner(0xc00013fba0, 0x908118)
/usr/lib/go-1.20/src/testing/testing.go:1576 +0x10b
created by testing.(*T).Run
/usr/lib/go-1.20/src/testing/testing.go:1629 +0x3ea
exit status 2
FAIL github.com/veraison/ear 5.194s

What did you expect to see?

Same as above, the test is stuck and times out leaving this crash trace!

[yogeshbdeshpande]

Same problem is seen with any go 1.20.x version

[gabyhelp]

Related Issues and Documentation

• crypto/ecdsa: GenerateKey infinite loop/reader EOF with all zero reader #58454
• math/rand: index out of range in (*rngSource).Int63 #21099 (closed)
• crypto/ecdsa: The GenerateKey method cannot maintain consistency #63463 (closed)
• runtime: 0xdeaddeaddeaddead crash #14667 (closed)
• cmd/go: unexpected panic when running go test on particular package without test files #25789 (closed)
• go 1.16: unexplained crash on `go test` or `go run` #45714 (closed)
• cmd/compile: panic during late opt while compiling (*ecdheKeyAgreement).processServerKeyExchange #27142 (closed)
• runtime: fatal error: unexpected signal during runtime execution #13046 (closed)
• Plis fixit! Its not good!!! #35957 (closed)
• x/crypto/wycheproof: TestHkdf cgo errors with boringcrypto #54557 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[seankhliao]

Duplicate of #58454

[seankhliao]

see also #62255