encoding/xml: does not reject colons in processing instruction targets

[DemiMarie]

Go version

1.22

Output of go env in your module/workspace:

What is on https://go.dev/play as of when this issue is filed

What did you do?

Ran this Go code:

package main

import (
	"encoding/xml"
	"fmt"
)

func main() {
	err := xml.Unmarshal([]byte(`<?a:b?><a/>`), new(interface{}))
	if err != nil {
		fmt.Printf("XML correctly rejected with error %#v", err)
	} else {
		fmt.Println("No error?")
	}
}

What did you see happen?

No error? output, indicating that unmarshalling was successful.

What did you expect to see?

An error because processing instruction targets cannot contain colons in a namespace-well-formed document.

[gabyhelp]

Related Issues and Documentation

• encoding/xml: allows a colon before or after an XML name #68294
• encoding/xml: accepts invalid XML with multiple colons #20396 (closed)
• encoding/xml: does not require whitespace before processing instruction value #68386
• encoding/xml: accepts various ill-formed XML #68293
• encoding/xml: accepts XML with no space between attributes #68385
• encoding/xml: accepts names containing `:` followed by a character that cannot start a Name #68392
• encoding/xml: Decoder does not reject xml-ProcInst preceeded by other data #65691
• encoding/xml: does not reject multiple attributes with the same namespace URL and local part #68297

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/609377 mentions this issue: encoding/xml: treat a namespaced name as two names, not one