encoding/xml: does not reject non-space before the root element or after the end of the root element

[DemiMarie]

Go version

1.22.5 (this is from pkg.go.dev)

Output of go env in your module/workspace:

Whatever is used on https://go.dev/play as of 2024-07-07

What did you do?

https://go.dev/play/p/SJIiUJ7VZW5

What did you see happen?

encoding/xml reports whitespace before and after the root element as xml.CharData, but this is wrong: the XML is ill-formed because XML entities are not allowed in these locations.

What did you expect to see?

An error indicating that the XML is ill-formed.

[gabyhelp]

Related Issues and Documentation

• encoding/xml: accepts various ill-formed XML #68293
• encoding/xml: Decoder does not reject xml-ProcInst preceeded by other data #65691
• encoding/xml: mismatching namespace error misses a space char #49635 (closed)
• encoding/xml: does not reject multiple attributes with the same namespace URL and local part #68297
• encoding/xml: CDATA section allows invalid characters #53728
• encoding/xml: does not reject duplicate attribute names #68295
• encoding/xml: minor improvement to namespace mismatch in closing tag #48890 (closed)
• encoding/xml: does not check namespace constraints that do not require keeping extra state #68296
• encoding/xml: accepts invalid XML with multiple colons #20396 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[cagedmantis]

cc @rsc

[cagedmantis]

Addressed in proposal #68299