x/tools/gopls: package not found when "linksInHover": "gopls" #68116
Comments
gopherbot
added
Tools
freeformz
changed the title
freeformz
changed the title
ansaba
added
the
NeedsInvestigation
|
Another engineer at $WORK was able to reproduce, although not consistently. |
|
CC @adonovan |
|
I can reproduce this in gopls' own main.go file on the telemetry.Start symbol. Wow, I can't believe I missed a bug this |
|
Change https://go.dev/cl/594556 mentions this issue: |
|
I installed from master and am having a similar problem. From doc link in the hover popup: (URL: http://127.0.0.1:63774/gopls/on0HKAhym30/pkg/github.com/google/flatbuffers?view=1#Builder) 
From the Source Action: (URL: http://127.0.0.1:63774/gopls/on0HKAhym30/pkg/github.com/google/flatbuffers/go?view=1#Builder Note the difference in the URLS.... http://127.0.0.1:63774/gopls/on0HKAhym30/pkg/github.com/google/flatbuffers?view=1#Builder The first one doesn't work, the second one does. |
|
Change https://go.dev/cl/595563 mentions this issue: |
…ix from pkgdoc URLs The package path in a /pkg URL does not want a module version suffix: the view specifies the versions of all packages. Remove them. Fixes golang/go#68116 Change-Id: Icbe7a6e7346d12456724d005fe8f755872657055 Reviewed-on: https://go-review.googlesource.com/c/tools/+/594556 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Alan Donovan <[email protected]> Reviewed-by: Robert Findley <[email protected]> (cherry picked from commit 1e6c1e2) Reviewed-on: https://go-review.googlesource.com/c/tools/+/595563 Auto-Submit: Robert Findley <[email protected]> Reviewed-by: Alan Donovan <[email protected]>
This release addresses the following gopls issues:
golang/go#68116, broken links to dependencies in the new integrated doc viewer.
golang/go#68169, a crash in package name completion.
golang/go#68213, a crash when hovering over an interface with an empty type set.
golang/go#68240, additional telemetry instrumentation to help inform decisions for [email protected]. (Note that this is local instrumentation only; a separate proposal will be filed to allow collection of this data from users who have opted in to sharing their telemetry data).
ATTENTION: Please answer these questions BEFORE submitting your issue. Thanks!
I am not sure if this is a gopls issue of vs-code go extension issue ... or both...
What did you do?
Enabled
Clicked on a doc link in the hover popup for grpc.DialContext and it took me to...
http://127.0.0.1:53693/gopls/exMLWbr5ON4/pkg/google.golang.org/[email protected]?view=1#DialContextAnd that returned
package not foundRight clicked -> Source Action -> Browse documentation for func grpc.DialContext -> which opened
http://127.0.0.1:53693/gopls/exMLWbr5ON4/pkg/google.golang.org/grpc?view=1#DialContext(note the difference in the urls)I tried this in multiple projects and different symbols with the same results (hover popup doc link returns package not found / Source Action works)
What did you expect to see?
The documentation for grpc.DialContext from gopls
What did you see instead?
package not found
Build info
The text was updated successfully, but these errors were encountered: