Skip to content

Commit b658265

Browse files
neildgopherbot
authored andcommitted
net/http: use default HTTP/2 frame scheduler
Use the default frame scheduler (currently round-robin) rather than overriding the default with the priority scheduler. The priority scheduler is slow, known buggy, and implements a deprecated stream prioritization mechanism. The default changed in x/net about a year ago, but we missed that net/http is overriding that default. Fixes #67706 Change-Id: I6d76dd0cc8c55eb5dec5cd7d25a5084877e8e8d9 Reviewed-on: https://go-review.googlesource.com/c/go/+/590796 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]> Auto-Submit: Damien Neil <[email protected]>
1 parent 93bbf71 commit b658265

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/net/http/server.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3598,9 +3598,7 @@ func (srv *Server) onceSetNextProtoDefaults() {
35983598
// Enable HTTP/2 by default if the user hasn't otherwise
35993599
// configured their TLSNextProto map.
36003600
if srv.TLSNextProto == nil {
3601-
conf := &http2Server{
3602-
NewWriteScheduler: func() http2WriteScheduler { return http2NewPriorityWriteScheduler(nil) },
3603-
}
3601+
conf := &http2Server{}
36043602
srv.nextProtoErr = http2ConfigureServer(srv, conf)
36053603
}
36063604
}

0 commit comments

Comments
 (0)