-
Notifications
You must be signed in to change notification settings - Fork 17.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/compile: emit error message on mismatch import path
Fixes #54542 Change-Id: I16cfb84fc54892923106d0a6f0b3ba810886d077 Reviewed-on: https://go-review.googlesource.com/c/go/+/596396 Auto-Submit: Cuong Manh Le <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: David Chase <[email protected]> Reviewed-by: Than McIntosh <[email protected]>
- Loading branch information
Showing
2 changed files
with
72 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
// run | ||
|
||
//go:build !js && !wasip1 | ||
|
||
// Copyright 2024 The Go Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style | ||
// license that can be found in the LICENSE file. | ||
|
||
package main | ||
|
||
import ( | ||
"bytes" | ||
"fmt" | ||
"os" | ||
"os/exec" | ||
"path/filepath" | ||
) | ||
|
||
const aSrc = `package a | ||
func A() { println("a") } | ||
` | ||
|
||
const mainSrc = `package main | ||
import "a" | ||
func main() { a.A() } | ||
` | ||
|
||
var srcs = map[string]string{ | ||
"a.go": aSrc, | ||
"main.go": mainSrc, | ||
} | ||
|
||
func main() { | ||
dir, err := os.MkdirTemp("", "issue54542") | ||
if err != nil { | ||
panic(err) | ||
} | ||
defer os.RemoveAll(dir) | ||
|
||
for fn, src := range srcs { | ||
if err := os.WriteFile(filepath.Join(dir, fn), []byte(src), 0644); err != nil { | ||
panic(err) | ||
} | ||
} | ||
|
||
if _, err := runInDir(dir, "tool", "compile", "-p=lie", "a.go"); err != nil { | ||
panic(err) | ||
} | ||
|
||
out, err := runInDir(dir, "tool", "compile", "-I=.", "-p=main", "main.go") | ||
if err == nil { | ||
panic("compiling succeed unexpectedly") | ||
} | ||
|
||
if bytes.Contains(out, []byte("internal compiler error:")) { | ||
panic(fmt.Sprintf("unexpected ICE:\n%s", string(out))) | ||
} | ||
} | ||
|
||
func runInDir(dir string, args ...string) ([]byte, error) { | ||
cmd := exec.Command("go", args...) | ||
cmd.Dir = dir | ||
return cmd.CombinedOutput() | ||
} |