{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":27522216,"defaultBranch":"master","name":"benchmarks","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-12-04T04:02:11.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1722002984.0","currentOid":""},"activityList":{"items":[{"before":"722bb6bd9253262d49b4eefac5597561722d197c","after":"c934f1d1595f6e949355c3a80800ff112ad5c735","ref":"refs/heads/master","pushedAt":"2024-09-19T17:32:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet: make it clear which benchmarks failed\n\nCurrently if there's a failure, you just get a message like \"benchmarks\nfailed to execute\" but that's not very specific. It can make recent logs\nlook like the culprit, when really it's further up in the log.\n\nChange-Id: Ib6ac96335b00418041495e5d1f9a6e2db920d387\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/614315\nReviewed-by: Michael Pratt \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sweet: make it clear which benchmarks failed"}},{"before":"35222a1842cb3371195dd043d3d2703be1d34178","after":"722bb6bd9253262d49b4eefac5597561722d197c","ref":"refs/heads/master","pushedAt":"2024-09-17T19:25:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet: only print git command stderr on failure\n\nCurrently a bunch of git helpers route git's stderr to Sweet's stderr,\nbut this just pollutes the output if everything worked fine. This change\ncaptures the output and dumps it only on error.\n\nChange-Id: I37e780e1deb98b44f13595fb8d53fd0568651de9\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/613955\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Michael Knyszek \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"sweet: only print git command stderr on failure"}},{"before":"fff5323d54cb7f201e81a318c8ac7f824045285c","after":"35222a1842cb3371195dd043d3d2703be1d34178","ref":"refs/heads/master","pushedAt":"2024-09-05T17:56:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I98e61b5bc4f5c054fde9c0a43690733421f77939\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/610659\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt \nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Gopher Robot ","shortMessageHtmlLink":"go.mod: update golang.org/x dependencies"}},{"before":"b7c12939d0ca9c090afce031c8284a20d9c1ec36","after":"fff5323d54cb7f201e81a318c8ac7f824045285c","ref":"refs/heads/master","pushedAt":"2024-09-05T00:35:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: fix printf(var) mistakes detected by latest printf checker\n\nUsed %q instead of %s when reporting an unexpected body to make\npotential non-printable characters easier to see.\n\nFor golang/go#69267.\n\nChange-Id: Ice78a175df5770afd20189b93c9659b9e966c9bb\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/610915\nReviewed-by: Dmitri Shuralyov \nTryBot-Bypass: Dmitri Shuralyov \nAuto-Submit: Dmitri Shuralyov \nReviewed-by: Tim King ","shortMessageHtmlLink":"all: fix printf(var) mistakes detected by latest printf checker"}},{"before":"b881d422b7f483b4270eacc3fa56affd962bae3e","after":"b7c12939d0ca9c090afce031c8284a20d9c1ec36","ref":"refs/heads/master","pushedAt":"2024-08-06T19:11:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: I70a067994f1919fdf0b4044b015d665cd3a42839\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/603555\nReviewed-by: Dmitri Shuralyov \nReviewed-by: David Chase \nAuto-Submit: Gopher Robot \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go.mod: update golang.org/x dependencies"}},{"before":"c9275a8d4254b6f3f575788d64fdac6c346a3e2f","after":"b881d422b7f483b4270eacc3fa56affd962bae3e","ref":"refs/heads/master","pushedAt":"2024-07-31T19:34:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet: split benchmark results from log and/or debug output\n\nCurrently benchmark output all comes out in one big stream and ends up\nin the results//.results file. Recently, we\nstarted dumping a lot more logging information from benchmarks by\ndefault, but this has caused problems with benchmark result parsing,\nsince they contain lines that look naively like key-value pairs in the\nbenchmark format.\n\nThis change resolves this problem by splitting the benchmark result\nstream from the log and/or debug output stream, placing the latter in\nresults//toolchain-name>.log. By convention, we make it so\nthat all benchmark driver binaries emit benchmark results to stdout and\neverything else to stderr to easily separate the streams in the harness\nand redirect them to different files.\n\nChange-Id: Iea4cc253a72db176378a6cc9f68b7f36b9ff60ae\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/602135\nReviewed-by: Michael Pratt \nAuto-Submit: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sweet: split benchmark results from log and/or debug output"}},{"before":"af1e9c0c84e0402a40ae69cb2a6e8fc20c406c46","after":"c9275a8d4254b6f3f575788d64fdac6c346a3e2f","ref":"refs/heads/master","pushedAt":"2024-07-31T17:45:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet: only enable gvisor benchmark by default for amd64\n\nCurrently this benchmark suite only run on amd64. This CL removes it\nfrom the default benchmarks for other architectures, so that \"sweet run\"\ncan pass by default.\n\nThis CL also adds a prerequisite check for amd64, so that it can report\nerrors in advance.\n\nFixes golang/go#67869\n\nChange-Id: I0454d5557bb0587c1c0314a42b02bf88105a2fe4\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/601075\nReviewed-by: Mauri de Souza Meneguzzo \nReviewed-by: Michael Knyszek \nReviewed-by: Austin Clements \nAuto-Submit: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sweet: only enable gvisor benchmark by default for amd64"}},{"before":"c5c50407248a0dd4712c9818a8580bcaff350d68","after":"af1e9c0c84e0402a40ae69cb2a6e8fc20c406c46","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/benchmarks/internal/driver: delete now-unused diagnostics code\n\nChange-Id: Ie4376c70a17c718373064d30577b3afef0f5365b\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600070\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"sweet/benchmarks/internal/driver: delete now-unused diagnostics code"}},{"before":"24f05dceb12345543d802f6a98e3c502e42a27b1","after":"c5c50407248a0dd4712c9818a8580bcaff350d68","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/benchmarks/internal/server: delete now-unused code\n\nChange-Id: I5770f324363d8c02987e7f99164be9db91bc4f68\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600066\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"sweet/benchmarks/internal/server: delete now-unused code"}},{"before":"09bfb8b0018e2255062b86b12af916baf9177a3d","after":"24f05dceb12345543d802f6a98e3c502e42a27b1","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:37.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/benchmarks/cockroachdb: use new diagnostics framework\n\nChange-Id: I6e155eee914428ebb665a02264f648ea17bcd73c\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600063\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"sweet/benchmarks/cockroachdb: use new diagnostics framework"}},{"before":"3314f5f3ef5d3542c3fb1711f29e14bd6f53b242","after":"09bfb8b0018e2255062b86b12af916baf9177a3d","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/benchmarks/etcd: use new diagnostics framework\n\nChange-Id: I242b0f6a6a857277023cbcd7a1ba5b204f278a9e\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600064\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"sweet/benchmarks/etcd: use new diagnostics framework"}},{"before":"73a0ff411dedf641b27ca1fc551adec70f18dc68","after":"3314f5f3ef5d3542c3fb1711f29e14bd6f53b242","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/benchmarks/go-build: use new diagnostics framework\n\nChange-Id: I77f8b37288ee6bb72a34a46aac4450e40559caaf\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600068\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"sweet/benchmarks/go-build: use new diagnostics framework"}},{"before":"d9ce3098fd293dc583cd9b8cb25081d6a5378482","after":"73a0ff411dedf641b27ca1fc551adec70f18dc68","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/benchmarks/gvisor: use new diagnostics framework\n\nChange-Id: I245edaf771c0d8698d4a28fcb064362d09911a4e\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600067\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Knyszek ","shortMessageHtmlLink":"sweet/benchmarks/gvisor: use new diagnostics framework"}},{"before":"bb87b64003560c5f950bcc2583c7cb86cd32cbaf","after":"d9ce3098fd293dc583cd9b8cb25081d6a5378482","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/benchmarks/internal/driver: use new diagnostics framework\n\nChange-Id: I95ba76c5865c416fd768f1a5f0c1cfeeb8c997e7\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600069\nReviewed-by: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sweet/benchmarks/internal/driver: use new diagnostics framework"}},{"before":"5a17dd9b7da15de1fdca18fd5ca65cef7946fa4a","after":"bb87b64003560c5f950bcc2583c7cb86cd32cbaf","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/benchmarks/internal/server: collect at least one profile\n\nFor profiles that can't be truncated, make sure we collect at least\none 1-second profile from servers. This is important for PGO\nbenchmarks, which must first do a profile run. Etcd, in particular,\nmay not run long enough for a complete profile without this.\n\nChange-Id: I4f26dd43d0a3cfd5fa7a4eda488e8b71bbfb65f0\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600756\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Knyszek ","shortMessageHtmlLink":"sweet/benchmarks/internal/server: collect at least one profile"}},{"before":"b1b06779374ea41ed7b93531124dcd5b6a7fe2bb","after":"5a17dd9b7da15de1fdca18fd5ca65cef7946fa4a","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet: new diagnostics framework\n\nThis new framework does several things. Primarily, it consolidates the\nmanagement of diagnostics files (profiles and traces). It's designed\nto be flexible enough for the myriad needs of different benchmarks.\n\nIt has a concept of \"committed\" and \"uncommitted\" diagnostic files.\nThis will be particularly important for servers, where we may have to\ntruncate diagnostic data being gathered from an HTTP endpoint.\nUncommitted diagnostics are discarded at the end of the benchmark.\n\nMeanwhile, the concept of a committed diagnostic also lets us\nconsolidate the profile merging logic. With this new framework, you\nsimply ask for multiple files of the same diagnostic type, and when\neverything is committed at the end, it will do any necessary profile\nmerging.\n\nFor diagnostics fetched over HTTP in particular, this new framework\nlets us fix a significant drawback to runtime trace collection.\nPreviously, we had to collect traces in many small increments (we used\n1 second), which makes the resulting traces basically unusable. As of\nGo 1.23, traces can be truncated, but the framework had no ability to\ncollect a truncatable diagnostic. With this CL, HTTP collection\nunderstands which diagnostics types can be truncated, and switches to\ncollecting a single long-running diagnostic and cutting it off at the\nend of the benchmark.\n\nWe'll push this through each benchmark and then remove the old\nframework.\n\nChange-Id: Ic9a189123f248aea13f92ef8961e9873c7cf9a6d\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600062\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Knyszek ","shortMessageHtmlLink":"sweet: new diagnostics framework"}},{"before":"84854447c33913500220ab38096ba6619e17c105","after":"b1b06779374ea41ed7b93531124dcd5b6a7fe2bb","ref":"refs/heads/master","pushedAt":"2024-07-29T19:23:17.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet: simplify diagnostics config handling\n\nCurrently, diagnostics track and pass around a potentially different\nresults directory for each diagnostic type. In practice, these are all\nalways the same directory.\n\nTrying to keep track of potentially different per-type directories is\ngoing to get cumbersome in some upcoming changes, so this CL\nsimplifies all of this by replacing the per-type directory\nconfiguration with a single results directory.\n\nThis necessarily changes the way we pass this configuration to the\nbenchmark drivers. We take advantage of this opportunity to clean that\nup as well. Now, the entire driver diagnostics configuration is\nrepresented by a single diagnostics.DriverConfig type, and this type\ncan be \"serialized\" to and \"deserialized\" from command line flags, as\nsymmetric operations.\n\nChange-Id: Ifbeb7a5d456dfcd6b6211dfb2b870f41bb7c5c70\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600058\nReviewed-by: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sweet: simplify diagnostics config handling"}},{"before":"d79c9b6293e459d10b0ff35745684530b3cc3c9b","after":null,"ref":"refs/heads/dependabot/go_modules/google.golang.org/grpc-1.64.1","pushedAt":"2024-07-26T14:09:44.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"}},{"before":null,"after":"d79c9b6293e459d10b0ff35745684530b3cc3c9b","ref":"refs/heads/dependabot/go_modules/google.golang.org/grpc-1.64.1","pushedAt":"2024-07-26T14:05:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1\n\nBumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.64.0 to 1.64.1.\n- [Release notes](https://github.com/grpc/grpc-go/releases)\n- [Commits](https://github.com/grpc/grpc-go/compare/v1.64.0...v1.64.1)\n\n---\nupdated-dependencies:\n- dependency-name: google.golang.org/grpc\n dependency-type: indirect\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"build(deps): bump google.golang.org/grpc from 1.64.0 to 1.64.1"}},{"before":"43f392302dd9c7cc7482fa8ffa6e4cb3fad6200b","after":"84854447c33913500220ab38096ba6619e17c105","ref":"refs/heads/master","pushedAt":"2024-07-26T14:04:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"all: update cloud.google.com/go\n\nWhen using a simple go.work, like:\n\n\tgo 1.23\n\n\tuse .\n\nBuilds fail with:\n\n\t$ go build golang.org/x/benchmarks/...\n\t../../go/pkg/mod/cloud.google.com/go/storage@v1.18.2/bucket.go:27:2: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:\n\t\tcloud.google.com/go v0.97.0 (/usr/local/google/home/mpratt/go/pkg/mod/cloud.google.com/go@v0.97.0/compute/metadata)\n\t\tcloud.google.com/go/compute/metadata v0.3.0 (/usr/local/google/home/mpratt/go/pkg/mod/cloud.google.com/go/compute/metadata@v0.3.0)\n\nI don't understand why adding a go.work causes this, but there is no\nharm in updating cloud.google.com/go to a newer version with no\nconflicting module.\n\nChange-Id: I346eb5e8b5c4ba307fd8d9948026d8206af8564c\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/601196\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Knyszek ","shortMessageHtmlLink":"all: update cloud.google.com/go"}},{"before":"0997f8fb1e6cce08146f10eef20a5895c6c5fe1b","after":"43f392302dd9c7cc7482fa8ffa6e4cb3fad6200b","ref":"refs/heads/master","pushedAt":"2024-07-24T21:18:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/cmd/sweet: fix benchmark error report\n\nCL 600235 added code to print the benchmark log tail on failure, but\nthat code overwrote the error from the benchmark itself, causing the\nlog print to print a useless (generally ) error. Fix this.\n\nChange-Id: I4cd6bfeb08108b66fc5450c9e64bb13ed9fc1628\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600795\nAuto-Submit: Austin Clements \nReviewed-by: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sweet/cmd/sweet: fix benchmark error report"}},{"before":"2ef16eb7fa3bfb216e98b8fd9b3475b0e0d13a38","after":"0997f8fb1e6cce08146f10eef20a5895c6c5fe1b","ref":"refs/heads/master","pushedAt":"2024-07-24T14:59:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet: apply flags to cockroachdb 'go build' based on 'go version'\n\nCurrently, the cockroachdb benchmark is built by passing a build tag\n(untested_go_version) unconditionally, and we also try to build with and\nwithout '-checklinkname=0' passed to the linker. These are required\nbecause some CockroachDB packages reach into the runtime internals.\n\nThe current approach doesn't work well across Go versions because\nsetting \"untested_go_version\" for older toolchains causes a symbol\nconflict (it ends up enabling multiple files with the same definition).\nWe can fix this upstream, but we also need a fix in the short term.\nPlus, it'll help to clean up this logic and make it more explicit.\n\nSo, this CL parses 'go version' in a dead-simple way to determine what\nto do. If we're using an older version of Go and the version is\nwell-defined, then we never use 'untested_go_version'. But if the\nversion of Go is explicitly a development version or newer than Go\n1.24, then we do.\n\nSimultaneously, we only pass -checklinkname=0 to the linker if the\ntoolchain version is >= 1.23. We always pass it for development Go\nversions.\n\nFixes golang/go#68555.\n\nChange-Id: Ieaad89cb6a92bdeee2636dc62b5b3a26ac317b5f\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest,x_benchmarks-go1.22-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600475\nReviewed-by: Austin Clements \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Michael Knyszek ","shortMessageHtmlLink":"sweet: apply flags to cockroachdb 'go build' based on 'go version'"}},{"before":"de01f140e5d02c45101bd1b4493cf0ee9e808b98","after":"2ef16eb7fa3bfb216e98b8fd9b3475b0e0d13a38","ref":"refs/heads/master","pushedAt":"2024-07-22T22:15:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/cmd/sweet: report log tail on failure\n\nOften benchmark errors are in their own stderr log. Try to extract and\nreport them from the suite runner.\n\nChange-Id: I70ac31ba73e7df189535787b6dc617133d4596e1\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600235\nReviewed-by: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Austin Clements ","shortMessageHtmlLink":"sweet/cmd/sweet: report log tail on failure"}},{"before":"302fed1bce19137691c4453f71cdac6218ba088e","after":"de01f140e5d02c45101bd1b4493cf0ee9e808b98","ref":"refs/heads/master","pushedAt":"2024-07-22T21:40:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/harnesses: bypass Go build version check in github.com/cockroachdb/swiss\n\nWithout this, CockroachDB can't build at tip.\n\nChange-Id: Icb7e969e1f7cfb98f15f1f2991213ab67bcb0124\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600196\nReviewed-by: Michael Knyszek \nAuto-Submit: Austin Clements \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sweet/harnesses: bypass Go build version check in github.com/cockroac…"}},{"before":"f8da0b75f25fbd98eb9cb4fc163f1571da935aae","after":"302fed1bce19137691c4453f71cdac6218ba088e","ref":"refs/heads/master","pushedAt":"2024-07-22T17:01:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/harnesses: make git less chatty more\n\nIn CL 600060, I made most calls to git less chatty, but missed one.\n\nChange-Id: Ieec2b7216467c5d5f40a25c20506eca945fa6ada\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600115\nAuto-Submit: Austin Clements \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Knyszek ","shortMessageHtmlLink":"sweet/harnesses: make git less chatty more"}},{"before":"779839a41c4e52dfd2de41247ec5c183362f23dd","after":"f8da0b75f25fbd98eb9cb4fc163f1571da935aae","ref":"refs/heads/master","pushedAt":"2024-07-22T14:55:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go.mod: bump version to go 1.21\n\nAlso run `go mod tidy`.\n\nChange-Id: Ia0402b5a282ebaa6ec1fc8d75463bf1295573484\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/599715\nAuto-Submit: Michael Knyszek \nReviewed-by: Austin Clements \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go.mod: bump version to go 1.21"}},{"before":"65d9afce5ef72406f2cfce19f02143c4a07fe649","after":"779839a41c4e52dfd2de41247ec5c183362f23dd","ref":"refs/heads/master","pushedAt":"2024-07-22T14:54:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet: collect and dump only hijacked fd 2 for cockroachdb\n\nCurrently the performance testing builders are failing because the\nCockroachDB servers produce far too much log data for\nperfdata.golang.org to handle, and it gets shipped off along with the\nbenchmark data (it just ends up in the result file). This change stops\nlogging everything CockroachDB does to stderr and instead redirects to a\ndedicated directory. This directory should remain if anything goes\nwrong, so we can still use it for debugging, but in normal usage it'll\nget blown away. The one thing we want from this directory, however, is\nthe output originally sent to fd 2 before it was hijacked by\nCockroachDB. This output includes things like runtime printlns from\nGODEBUG=gctrace=1, among other things, which is important to preserve\nfor our debugging.\n\nFixes golang/go#68517.\n\nChange-Id: I319d37e174675a1e7de7d9fcb4ca06076c6c8daf\nCq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/599455\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Austin Clements ","shortMessageHtmlLink":"sweet: collect and dump only hijacked fd 2 for cockroachdb"}},{"before":"269c3a4ac837ec437932400eccc3cca849db8b4d","after":"65d9afce5ef72406f2cfce19f02143c4a07fe649","ref":"refs/heads/master","pushedAt":"2024-07-22T13:48:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/benchmarks/internal/driver: don't swallow perf stderr\n\nIt took me way too long to figure out why I wasn't getting perf data\nwhen I had forgotten to enable the magic sysctls and wasn't getting\nthe usual hint from perf.\n\nChange-Id: I5e518b024dccff45ff06daa84ac866708c1d4ddc\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600061\nReviewed-by: Michael Knyszek \nAuto-Submit: Austin Clements \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sweet/benchmarks/internal/driver: don't swallow perf stderr"}},{"before":"13000c5a29f645a9cddfa71b8d15be3cdf53672d","after":"269c3a4ac837ec437932400eccc3cca849db8b4d","ref":"refs/heads/master","pushedAt":"2024-07-22T13:47:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet/harnesses: don't swallow git stderr\n\nChange-Id: I8ad1a29afc9a7784659fa08f04aeaaf48f30c1c3\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600059\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Michael Knyszek \nAuto-Submit: Austin Clements ","shortMessageHtmlLink":"sweet/harnesses: don't swallow git stderr"}},{"before":"bff3eae759927857096fa8eac621bc7664bb353f","after":"13000c5a29f645a9cddfa71b8d15be3cdf53672d","ref":"refs/heads/master","pushedAt":"2024-07-22T13:46:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sweet: helper to run functions in parallel\n\nChange-Id: I0dcdbaecaef7a8b2f08291574229716c6b27079d\nReviewed-on: https://go-review.googlesource.com/c/benchmarks/+/600057\nReviewed-by: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Austin Clements ","shortMessageHtmlLink":"sweet: helper to run functions in parallel"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEuyZ0aQA","startCursor":null,"endCursor":null}},"title":"Activity · golang/benchmarks"}