Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to combine both branches (main + mac) into the one? #92

Closed
bigcat88 opened this issue May 22, 2024 · 2 comments
Closed

Comments

@bigcat88
Copy link

This would greatly simplify the use of these wonderful Nodes.

Whether a node is running on a Mac or not is very easy to determine.
Whether the Python package for AMD is installed is also a 2-line check.

Or is I missing something obvious?

@gokayfem
Copy link
Owner

gokayfem commented May 22, 2024

autogptq library is not working on mac devices which internlm model was requires it thats why i seperated them. also there was a problem about the pycpuinfo package that needs a lower version for windows and linux to load faster and newer version for mac. i can delete the internlm node and autogptq dependency, since there are a lot of vlm models released after that model. we can combine them i think.

@bigcat88
Copy link
Author

also there was a problem about the pycpuinfo package that needs a lower version for windows and linux to load faster and newer version for mac.

this can be done in the requirements.txt (specify separate versions of pycpuinfo for Mac and linux, i mean)

i can delete the internlm node and autogptq dependency, since there are a lot of vlm models released after that model. we can combine them i think.

that will be awesome, as there are not so much working local vlm nodes except these repo :)

@gokayfem gokayfem closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants