Add Mustache template support

[ghost]

Mustache is langugage independent template system. If you implement mustache support I think more people migrated from other static site generators.

Thanks,

[spf13]

I agree and it shouldn't be very difficult. Could seamlessly support both
based on template extension. Pull request anyone?

Steve Francia
spf13.com
@spf13

On Aug 26, 2013, at 5:08 PM, Xavier [email protected] wrote:

Mustache is langugage independent template system. If you implement
mustache support I think more people migrated from other static site
generators.

Thanks,

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/60
.

[ghost]

If I were Go programmer, I will do, but right now, I'm just user of static content generators. I tried several: nanoc, acrylamid, hakyll, but all of these have an issue: 'if you want to use me, you have to learn new template syntax'.

Very nice if someone could implement it,

Thanks,

[spf13]

I'm all in favor of supporting mustache and any other templating language
people want to include. As I've already demonstrated with support for yaml,
json and toml I think Hugo should be pluggable to handle a variety of
different content and format and all without any additional configuration.
It just works when you use a supported file. For the first iteration I
choose go templates because that had the best support in go. mustache
support is decent in go and should be next. As far as I know there aren't
any other template formats supported yet.

The catch is for any of these additional formats I need someone to be the
maintainer of their support. I'm already maintaining the set we currently
support, but doubt I could keep track of many more.

Anyone up for taking on mustache?

Steve Francia
http://stevefrancia.com
http://spf13.com
http://twitter.com/spf13

On Tue, Aug 27, 2013 at 5:07 AM, Xavier [email protected] wrote:

If I were Go programmer, I will do, but right now, I'm just user of static
content generators. I tried several: nanoc, acrylamid, hakyll, but all of
these have an issue: 'if you want to use me, you have to learn new template
syntax'.

Very nice if someone could implement it,

Thanks,

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/60#issuecomment-23322269
.

[yobennett]

I'll take a stab at putting together support for Mustache. I haven't made any contributions to a Go project yet so it'd be great to get some feedback once I submit a pull request.

[spf13]

I'd love to help provide feedback and even help code it, just can't
maintain long term.

Steve Francia
http://stevefrancia.com
http://spf13.com
http://twitter.com/spf13

On Tue, Aug 27, 2013 at 11:34 PM, Bennett [email protected] wrote:

I'll take a stab at putting together support for Mustache. I haven't made
any contributions to a Go project yet so it'd be great to get some feedback
once I submit a pull request.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/60#issuecomment-23387691
.

[yobennett]

Awesome! I'd gladly maintain, @spf13. I'll have some free time next week to get started.

[Mistobaan]

I would like to add amber as template engine: https://github.com/eknkc/amber

[avidal]

Should this issue be closed? There's already a dependency on the eknkc/amber package in template/bundle/template.go

[spf13]

Amber came out of this, mustache still hasn’t… I suppose it’s still open.

[avidal]

Ah, I see. I'm looking to contribute so I poked to the back of the issue list and saw this one; wasn't sure if it was a sign of lack of triaging/caretaking or not :)

[mohae]

Looking into this, it appears that the mustache package in Go, hoisie/mustache, is no longer maintained. The last commit was May 13, 2013, with pending pull requests.

There are more recent forks out there, but I didn't check what changes they made.

Is mustache something that should be a milestone given its state in Go?

[spf13]

I suppose not. It's sad there isn't better mustache support in Go. Until there is we should mark this as future.

[mohae]

I forked what seemed to be the best version of mustache: Wuvist/mustache, went through all the pull requests on https://github.com/hosie/mustache, and updated the tests.

I didn't integrate all of the outstanding pull requests.

I used the updated tests from @adammck but had to update a signifcant amount of their expectations to meet what I though mustache expected. They all pass, though that doesn't mean they are all correct. I have a list of the failed test lines that were changed and will post that as an issue on my repo.

Beyond that, I haven't had a chance to do much with it, but I will probably set up a Hugo site using it to see what breaks on the mustache side.

Hopefully, it support for it will be added to Hugo soon.

[adammck]

The tests in hoisie/mustache/pull/43 were generated from the Mustache spec by this little tool. I believe that the expectations are correct, but the Mustache library is non-compliant.

[mohae]

@adammck Thanks for your input!

I had read the Mustache docs, but they were unclear on what should occur in certain situations, the ones which the Mustache library failed on. I couldn't find anything clearer in other tests I looked at so I did a combination of looking at the strings and what I thought the resulting substitutions would look like, which got rough on the tests that tended to fail, and the output, for simpler cases, from trymustache.com. The results tended to match the results from the library, but I did not attach any validity to that coincidence, hence my comments about passing and correctness.

I wish I had seen the specs and your tool earlier. I'll go through the spec and your tool to get a better understanding of Mustache and what needs to be done to the library.

[mohae]

After review of the spec objects, I have reverted the Mustache tests to @adammck's version. I will update when the Mustache library is compliant to the current set of tests.

[mohae]

@spf13 can this be pushed to 'Future' instead of .13 milestone?

There is a chance I will get this done sooner than that, but I still wouldn't be comfortable having it as part of the next release, esp. since there's enough changes in it already.

When I originally said I'd add support it was based on using the existing Go mustache package, but that is not a workable solution imo, or there seems to be a reason, or reasons, why there are so many abandoned forks. That coupled with the original author's response to using the Mustache spec tests led me to decide that a different package should be used.

Unfortunately that meant writing one from scratch. The package, when completed, being so new, is the reason why I wouldn't be comfortable having it as part of the next release, even if it were completed before then.

[spf13]

Totally valid reasons. Bumping.

[bep]

@mohae status?

[bep]

This issue has been automatically marked as stale because it has not been commented on for at least four months.

The resources of the Hugo team are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, and you feel that it is still valuable, please open a proposal at https://discuss.gohugo.io/.

This issue will automatically be closed in four months if no further activity occurs. Thank you for all your contributions.

[bep]

Note/Update: This issue is marked as stale, and I may have said something earlier about "opening a thread on the discussion forum". Please don't.

If this is a bug and you can still reproduce this error on the latest release or the master branch, please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.

[bep]

I would say that, this issue being so old, and no one has stepped up to the task of implementing it: If someone wants to create a PR with this feature, he/she should create a new tracking issue.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.