Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column heights in the footer aren't proportional #61

Open
digitalcraftsman opened this issue Jul 28, 2017 · 3 comments
Open

Column heights in the footer aren't proportional #61

digitalcraftsman opened this issue Jul 28, 2017 · 3 comments

Comments

@digitalcraftsman
Copy link
Member

The left column is much higher than the others. Is a 4-column layout an alternative?

footer

@budparr
Copy link

budparr commented Jul 31, 2017

I agree. The footer needs work in general.

@XhmikosR
Copy link
Contributor

XhmikosR commented Aug 6, 2017

Since you use flexbox it's pretty easy to achieve anything you want.

@crgeary
Copy link
Contributor

crgeary commented Dec 7, 2018

This has changed a fair bit from the above screenshot. Looks like it's now a bit too one-sided with the right side of the footer. This is because the sponsors butt up against the right edge of the container, but the content on the left is centred instead.

image

It also seems rather odd to me that the copyright text doesn't line up with the footer container, you can't tell at the moment because the content is centred, but it's noticeable if the text is left aligned. Might just be me but that seems a bit odd. It's also hidden on a tablet device as the text is sitting behind the sticky buttons.

I'd be happy to look into fixing these. I'm not familiar with the css framework that's used, but I'm happy to take a look if the above seem suitable fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants