🤗 [Question]: Is there any way to log request id on handler?

[gunb0s]

Question Description

i'm new to go fiber and develop with uber zap, fx.
The problem is i know how to log request id in middleware logger, But I made a another logger to use on handler and using it by dependency injection.
how can i log request id on second logger?

i guess that i can make a log function to accept fiber context as parameter, and extract request id from it,
but I wish there were other options than this, like in middleware, which can be pre-set

Code Snippet (optional)

var Module = fx.Module(
	"external",
	fx.Provide(
		database.NewPostgres,
		logger.New,
	),
)

type External struct {
	fx.In

	Logger *logger.Sugared
	DB     *gorm.DB
}

type productService struct {
	ex external.External
}

func (s productService) GetAllProducts(c dto.GetAllProductParam) ([]model.Product, int, error) {
	var products []model.Product
	var count int64
	limit, offset := c.Limit, c.Offset
	queryResult := s.ex.DB.Scopes(database.Paginate(limit, offset)).Find(&products)
	queryResult = s.ex.DB.Model(&model.Product{}).Count(&count)
	
	s.ex.Logger.Printf("request Id needed")

	return products, int(count), queryResult.Error
}

Checklist:

• I agree to follow Fiber's Code of Conduct.
• I have checked for existing issues that describe my questions prior to opening this one.
• I understand that improperly formatted questions may be closed without explanation.

[welcome]

Thanks for opening your first issue here! 🎉 Be sure to follow the issue template! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

[ReneWerner87]

you can use the https://docs.gofiber.io/contrib/fiberzap_v2.x.x/fiberzap/ for this

https://github.com/gofiber/contrib/blob/main/fiberzap/zap.go#L168

[gunb0s]

you can use the https://docs.gofiber.io/contrib/fiberzap_v2.x.x/fiberzap/ for this

https://github.com/gofiber/contrib/blob/main/fiberzap/zap.go#L168

this way needs fiber context at every situation.. right?

[ReneWerner87]

yes as middleware it works directly with the fiber context

https://github.com/gofiber/contrib/blob/f4145f79af4e39b26515340bf92c879ccc350b4f/fiberzap/zap_test.go#L290-L308

the question is whether you need a req/res logger or just want to log additional information

the variant I have shown you is an independent middleware for logging the req/res data

[gunb0s]

yes as middleware it works directly with the fiber context

https://github.com/gofiber/contrib/blob/f4145f79af4e39b26515340bf92c879ccc350b4f/fiberzap/zap_test.go#L290-L308

the question is whether you need a req/res logger or just want to log additional information

the variant I have shown you is an independent middleware for logging the req/res data

my question is about that i want to log additional information, not in req/res logger
like trace id, in opentelemetry

[ReneWerner87]

ok, how do you generate this requestID ? with the middleware?
https://docs.gofiber.io/api/middleware/requestid

[ReneWerner87]

you can always inject a middleware that logs this id or does other things

	app.Use(func(c *fiber.Ctx) error {
        // log requestId
        log.Println("requestId:", c.Locals("requestid")) // requestId from the locals(context) object - https://docs.gofiber.io/api/middleware/requestid#config
        log.Println("requestId:", c.Get(fiber.HeaderXRequestID)) // requestId from the request header
        return c.Next()
    })

[gunb0s]

Instead of using middleware, if I want to log additional information in an API controller or service, do I always need the Fiber context to get the request ID? If that's the case, it feels inconvenient to pass the context to the logger each time like this:

sugarLogger.With(
	zap.String("requestID", context.Get(fiber.HeaderXRequestID)),
).Infof("Printf-style logging with context: %s", "additional info")

I'm looking for a different approach because it seems cumbersome to log this way. The reason I want to implement this is to distinguish logs from the same request when multiple requests come in simultaneously.

[ReneWerner87]

all request and response information can be found in the fiber context
in order to access this information, it is necessary to use it
you can also extract this information and pass it on later or add it beforehand

app.Use(func(c *fiber.Ctx) error {
		// extend and (TODO) store this logger
		zap.With(zap.String("requestId", c.Get(fiber.HeaderXRequestID)).Info("requestId"))
		return c.Next()
})

[gunb0s]

I think this way is best for my situation, I'll try it thank you!!