Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quaternions made with Quaternion(arc_from: Vector3, arc_to: Vector3) with an angle under 0.0045 radians will not do anything #102679

Open
Xorblax opened this issue Feb 10, 2025 · 4 comments

Comments

@Xorblax
Copy link

Xorblax commented Feb 10, 2025

Tested versions

Tested in 4.4.beta3

System information

Godot v4.4.beta3 - Windows 10 (build 19045) - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; 32.0.15.6636) - AMD Ryzen 5 3600 6-Core Processor (12 threads)

Issue description

When creating a Quaternion with the (arc_from, arc_to) constructor, if the angle is less than what seems to be around 0.0045 radians, the resulting rotation won't do anything.

Steps to reproduce

Make a Quaternion using the (arc_from, arc_to) constructor, where the angle between the vectors is less than 0.0045 radians and try to rotate something with it.

Minimal reproduction project (MRP)

quaternion-issue.zip

@Xorblax Xorblax changed the title Quaternions made with Quaternion(arc_from: Vector3, arc_to: Vector3) with an angle under 0.005 radians will not do anything Quaternions made with Quaternion(arc_from: Vector3, arc_to: Vector3) with an angle under 0.0045 radians will not do anything Feb 10, 2025
@matheusmdx matheusmdx added this to the 4.4 milestone Feb 11, 2025
@matheusmdx
Copy link
Contributor

Seems to be a regression between 4.4 beta 1 and 4.4 beta 2, bisecting.

@AThousandShips
Copy link
Member

Sounds like it comes from:

@matheusmdx
Copy link
Contributor

Indeed, reverting pr #101797 fixes the issue.

CC @TokageItLab

@TokageItLab
Copy link
Member

This case depends on the error tolerance. A possible solution is to reduce the epsilon value as in #102144.

@AThousandShips AThousandShips moved this from Unassessed to Not Critical in 4.x Release Blockers Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Not Critical
Development

No branches or pull requests

4 participants