Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StyleBox inconsistencies - referred to as both "style_box" and "stylebox" #102041

Open
FireCatMagic opened this issue Jan 25, 2025 · 0 comments
Open

Comments

@FireCatMagic
Copy link

Tested versions

All

System information

N/A

Issue description

To start I'll show this single line:

draw_style_box(get_theme_stylebox(SN_STYLEBOX_PLUS), plus_rect);

Here you can see in draw_style_box the StyleBox is referred to as style_box while in get_theme_stylebox it is stylebox, missing an underscore.

In some places, variables that use StyleBox call it style_box while others call it stylebox. The class StyleBox has Box uppercase, so I think style_box makes more sense.
This isn't a major issue, this is just a thing I noticed that could be adjusted later for consistency. (or rename & deprecate functions or something)

Image

Image

Steps to reproduce

N/A

Minimal reproduction project (MRP)

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants