Merge pull request #762 from godot-rust/qol/clippy-maintenance

Clippy fixes for Rust 1.79

Author: Bromeon

godot-codegen/src/models/json.rs

@@ -8,7 +8,13 @@
 // TODO remove this warning once impl is complete
 // Several types have #[allow(dead_code)], can be subsequently removed.
 
-#![allow(clippy::question_mark)] // in #[derive(DeJson)]
+// In #[derive(DeJson)].
+#![allow(clippy::question_mark)]
+//
+// This file acts as deserialization check of the JSON file. Even if some fields are unused, having them declared makes sure they're
+// deserializable and conform to our expectations. It also doesn't add much value to annotate individual fields; it doesn't really
+// matter if some are unused because it's external input data.
+#![allow(dead_code)]
 
 use nanoserde::DeJson;
 

godot-macros/src/class/data_models/field_var.rs

@@ -195,7 +195,6 @@ impl GetterSetterImpl {
         let export_token = make_method_registration(
             class_name,
             FuncDefinition {
-                signature: signature.clone(),
                 signature_info: into_signature_info(signature, class_name, false),
                 // Since we're analyzing a struct's field, we don't have access to the corresponding get/set function's
                 // external (non-#[func]) attributes. We have to assume the function exists and has the name the user
@@ -205,7 +204,6 @@ impl GetterSetterImpl {
                 external_attributes: Vec::new(),
                 rename: None,
                 is_script_virtual: false,
-                has_gd_self: false,
             },
         );
 

godot-macros/src/class/data_models/func.rs

@@ -12,16 +12,13 @@ use quote::{format_ident, quote};
 
 /// Information used for registering a Rust function with Godot.
 pub struct FuncDefinition {
-    /// Raw information about the Rust function.
-    pub signature: venial::Function,
     /// Refined signature, with higher level info and renamed parameters.
     pub signature_info: SignatureInfo,
     /// The function's non-gdext attributes (all except #[func]).
     pub external_attributes: Vec<venial::Attribute>,
     /// The name the function will be exposed as in Godot. If `None`, the Rust function name is used.
     pub rename: Option<String>,
     pub is_script_virtual: bool,
-    pub has_gd_self: bool,
 }
 
 /// Returns a C function which acts as the callback when a virtual method of this instance is invoked.

godot-macros/src/class/data_models/inherent_impl.rs

@@ -176,12 +176,10 @@ fn process_godot_fns(
                 };
 
                 func_definitions.push(FuncDefinition {
-                    signature,
                     signature_info,
                     external_attributes,
                     rename,
                     is_script_virtual: is_virtual,
-                    has_gd_self,
                 });
             }
             ItemAttrType::Signal(ref _attr_val) => {

itest/repo-tweak/src/lib.rs

@@ -10,6 +10,7 @@ use std::collections::HashMap;
 #[derive(Debug)]
 pub struct Match {
     /// Position before pattern start marker.
+    #[allow(dead_code)] // False-positive, regression introduced in Rust 1.79.
     pub before_start: usize,
 
     /// Position at the beginning of the repetition (after marker + keys).

itest/rust/src/object_tests/object_swap_test.rs

@@ -34,7 +34,8 @@ macro_rules! swapped_free {
         let mut rhs = $rhs;
 
         // Standard DerefMut no longer works, as it checks the RTTI which then panics.
-        // std::mem::swap(&mut *lhs, &mut *rhs);
+        // #[allow]: we don't know the types inside the macro, and Rust still doesn't have typeof/decltype.
+        #[allow(clippy::missing_transmute_annotations)]
         std::mem::swap(&mut lhs, unsafe { std::mem::transmute(&mut rhs) });
 
         lhs.free();