Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow static agents to be deployed as a StatefulSet or as a DaemonSet #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

12345ieee
Copy link

@12345ieee 12345ieee commented Jan 11, 2025

Description

Allow static agents to be deployed as a StatefulSet or as a DaemonSet.
Support specifying volumeClaimTemplates, which allow static agents to keep their identity at restart

Some value keys have been renamed for consistency.

Relevant issues

Possible challenges

Keys that had deployment in their name have been changed to controller, this is a very minimal breaking change.
There are many other ways to write those keys, I await the maintainers' opinion.

Additional information

Because of the discussion in #111 I've kept the /godata persistence as a side effect of STS+volumeClaimTemplate support instead of implementing it as a first class feature.

Said persistence is achieved with (this will end up in the README and it's in commented values):

agent:
  controller:
    kind: "StatefulSet"
  persistence:
    claimTemplates:
      - metadata:
          name: godata
        spec:
          accessModes: ["ReadWriteOnce"]
          resources:
            requests:
              storage: SIZE
          storageClassName: NAME
    extraVolumeMounts:
      - name: godata
        mountPath: /godata

STS's podManagementPolicy is available since Kube 1.7, so there is no need to check capabilities.

Once the changes have been reviewed, iterated and approved I'll write out the Changelog changes.

Checklist

  • Chart version bumped in Chart.yaml
  • Any new variables have documentation and examples in values.yaml, even if commented out
  • Any new variables added to the README.md
  • Squash into a single commit (or explain why you'd prefer not to), except...
  • ...additional commit added for CHANGELOG.md entry
  • Helm lint + tests passing?

@12345ieee
Copy link
Author

Hi, can I do something else to help move this along?

@chadlwilson
Copy link
Member

It was still marked as draft, so I thought you were still working on it. In any case I haven't taken a look at it yet.

@12345ieee 12345ieee marked this pull request as ready for review January 20, 2025 16:08
@12345ieee
Copy link
Author

Ah sorry, take a look at your convenience.

And as a DaemonSet.
Support specifying volumeClaimTemplates, which allow static agents to keep their identity at restart

Some value keys have been renamed for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist /godata at static agent restart
2 participants