Allow static agents to be deployed as a StatefulSet or as a DaemonSet #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow static agents to be deployed as a StatefulSet or as a DaemonSet.
Support specifying volumeClaimTemplates, which allow static agents to keep their identity at restart
Some value keys have been renamed for consistency.
Relevant issues
/godata
at static agent restart #111Possible challenges
Keys that had
deployment
in their name have been changed tocontroller
, this is a very minimal breaking change.There are many other ways to write those keys, I await the maintainers' opinion.
Additional information
Because of the discussion in #111 I've kept the
/godata
persistence as a side effect of STS+volumeClaimTemplate support instead of implementing it as a first class feature.Said persistence is achieved with (this will end up in the README and it's in commented values):
STS's
podManagementPolicy
is available since Kube 1.7, so there is no need to check capabilities.Once the changes have been reviewed, iterated and approved I'll write out the Changelog changes.
Checklist
Chart.yaml
values.yaml
, even if commented outREADME.md
CHANGELOG.md
entry