Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Fingerprint Images #848

Closed
paganotoni opened this issue Jan 12, 2018 · 1 comment
Closed

Fingerprint Images #848

paganotoni opened this issue Jan 12, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@paganotoni
Copy link
Member

At this point, Buffalo is using the fingerprint strategy on compiled CSS and JS but it's not being used for images, it would be good to add this to images in order to make asset compilation consistent in that sense.

This may have an impact in other areas like CSS backgrounds and fonts but the solution may be already implemented into webpack.

Changes to solve this will mostly be related to the webpack configuration but we will need to add an image helper to resolve fingerprinted image URLs from the manifest.json file as we do for CSS and JS.

@paganotoni paganotoni self-assigned this Jan 12, 2018
@paganotoni paganotoni added the enhancement New feature or request label Jan 12, 2018
@stanislas-m
Copy link
Member

@paganotoni, I think #921 is related to this one: I tried the proposed change to the Manifest plugin, but since images are not in the manifest, it can't work.

@sio4 sio4 added this to the Backlog milestone Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants