From 1087627df9524a09aa12f646213bc77bccbc6b63 Mon Sep 17 00:00:00 2001
From: Simmo Saan <simmo.saan@gmail.com>
Date: Mon, 22 Apr 2024 15:44:03 +0300
Subject: [PATCH] Add quiet (-q) argument to update_suite (issue #1392)

---
 scripts/update_suite.rb                  |  9 +++++----
 tests/incremental/dune                   |  4 ++--
 tests/regression/24-octagon/dune         |  2 +-
 tests/regression/36-apron/dune           |  2 +-
 tests/regression/46-apron2/dune          |  2 +-
 tests/regression/52-apron-mukherjee/dune |  2 +-
 tests/regression/56-witness/dune         | 20 ++++++++++----------
 tests/regression/63-affeq/dune           |  2 +-
 tests/regression/77-lin2vareq/dune       |  2 +-
 tests/regression/78-termination/dune     |  2 +-
 tests/regression/dune                    |  2 +-
 11 files changed, 25 insertions(+), 24 deletions(-)

diff --git a/scripts/update_suite.rb b/scripts/update_suite.rb
index 70be6b6d85..208de14066 100755
--- a/scripts/update_suite.rb
+++ b/scripts/update_suite.rb
@@ -63,6 +63,7 @@ def clearline
 #Command line parameters
 #Either only run a single test, or
 #"future" will also run tests we normally skip
+quiet = ARGV.last == "-q" && ARGV.pop
 $dump = ARGV.last == "-d" && ARGV.pop
 sequential = ARGV.last == "-s" && ARGV.pop
 marshal = ARGV.last == "-m" && ARGV.pop
@@ -608,9 +609,9 @@ def run ()
   dirname = File.dirname(filepath)
   filename = File.basename(filepath)
   Dir.chdir(dirname)
-  clearline
+  clearline unless quiet
   id = "#{p.id} #{p.group}/#{p.name}"
-  print "Testing #{id}"
+  print "Testing #{id}" unless quiet
   begin
     Dir.mkdir(File.join($testresults, p.group)) unless Dir.exist?(File.join($testresults, p.group))
   rescue
@@ -635,7 +636,7 @@ def run ()
   end
 end
 $alliswell = projects.map{|p| p.testset.ok}.all?
-clearline
+clearline unless quiet
 
 #Outputting
 header = <<END
@@ -688,7 +689,7 @@ def run ()
   puts ("Results: " + theresultfile)
 end
 if $alliswell then
-  puts "No errors :)".green
+  puts "No errors :)".green unless quiet
 else
   puts "#{$failed.length} test(s) failed: #{$failed}".red
 end
diff --git a/tests/incremental/dune b/tests/incremental/dune
index 4c902d1183..35f3d43267 100644
--- a/tests/incremental/dune
+++ b/tests/incremental/dune
@@ -11,8 +11,8 @@
  (action
   (chdir ../..
    (progn
-     (run %{update_suite} -i) ; with AST comparison
-     (run %{update_suite} -c))))) ; with CFG comparison
+     (run %{update_suite} -i -q) ; with AST comparison
+     (run %{update_suite} -c -q))))) ; with CFG comparison
 
 (cram
  (applies_to :whole_subtree)
diff --git a/tests/regression/24-octagon/dune b/tests/regression/24-octagon/dune
index 0f9a0e1a1f..24e3405417 100644
--- a/tests/regression/24-octagon/dune
+++ b/tests/regression/24-octagon/dune
@@ -7,4 +7,4 @@
    (:update_suite ../../../scripts/update_suite.rb)
    (glob_files ??-*.c))
  (locks /update_suite)
- (action (chdir ../../.. (run %{update_suite} group octagon))))
+ (action (chdir ../../.. (run %{update_suite} group octagon -q))))
diff --git a/tests/regression/36-apron/dune b/tests/regression/36-apron/dune
index 099ec878b2..6ea87f5ba8 100644
--- a/tests/regression/36-apron/dune
+++ b/tests/regression/36-apron/dune
@@ -7,4 +7,4 @@
    (:update_suite ../../../scripts/update_suite.rb)
    (glob_files ??-*.c))
  (locks /update_suite)
- (action (chdir ../../.. (run %{update_suite} group apron))))
+ (action (chdir ../../.. (run %{update_suite} group apron -q))))
diff --git a/tests/regression/46-apron2/dune b/tests/regression/46-apron2/dune
index ca3efec235..cc0c04185c 100644
--- a/tests/regression/46-apron2/dune
+++ b/tests/regression/46-apron2/dune
@@ -7,4 +7,4 @@
    (:update_suite ../../../scripts/update_suite.rb)
    (glob_files ??-*.c))
  (locks /update_suite)
- (action (chdir ../../.. (run %{update_suite} group apron2))))
+ (action (chdir ../../.. (run %{update_suite} group apron2 -q))))
diff --git a/tests/regression/52-apron-mukherjee/dune b/tests/regression/52-apron-mukherjee/dune
index 62bcc41fdb..189a810a43 100644
--- a/tests/regression/52-apron-mukherjee/dune
+++ b/tests/regression/52-apron-mukherjee/dune
@@ -7,4 +7,4 @@
    (:update_suite ../../../scripts/update_suite.rb)
    (glob_files ??-*.c))
  (locks /update_suite)
- (action (chdir ../../.. (run %{update_suite} group apron-mukherjee))))
+ (action (chdir ../../.. (run %{update_suite} group apron-mukherjee -q))))
diff --git a/tests/regression/56-witness/dune b/tests/regression/56-witness/dune
index 422a710175..5155000010 100644
--- a/tests/regression/56-witness/dune
+++ b/tests/regression/56-witness/dune
@@ -11,16 +11,16 @@
  (action
   (chdir ../../..
    (progn
-     (run %{update_suite} apron-unassume-interval)
-     (run %{update_suite} apron-unassume-branch)
-     (run %{update_suite} apron-unassume-global)
-     (run %{update_suite} apron-unassume-priv)
-     (run %{update_suite} apron-unassume-priv2)
-     (run %{update_suite} apron-unassume-strengthening)
-     (run %{update_suite} mine-tutorial-ex4.10)
-     (run %{update_suite} hh-ex3)
-     (run %{update_suite} bh-ex1-poly)
-     (run %{update_suite} apron-unassume-precheck)))))
+     (run %{update_suite} apron-unassume-interval -q)
+     (run %{update_suite} apron-unassume-branch -q)
+     (run %{update_suite} apron-unassume-global -q)
+     (run %{update_suite} apron-unassume-priv -q)
+     (run %{update_suite} apron-unassume-priv2 -q)
+     (run %{update_suite} apron-unassume-strengthening -q)
+     (run %{update_suite} mine-tutorial-ex4.10 -q)
+     (run %{update_suite} hh-ex3 -q)
+     (run %{update_suite} bh-ex1-poly -q)
+     (run %{update_suite} apron-unassume-precheck -q)))))
 
 (cram
  (deps (glob_files *.c) (glob_files ??-*.yml)))
diff --git a/tests/regression/63-affeq/dune b/tests/regression/63-affeq/dune
index bdfd6192b7..af1738b06b 100644
--- a/tests/regression/63-affeq/dune
+++ b/tests/regression/63-affeq/dune
@@ -7,4 +7,4 @@
    (:update_suite ../../../scripts/update_suite.rb)
    (glob_files ??-*.c))
  (locks /update_suite)
- (action (chdir ../../.. (run %{update_suite} group affeq))))
+ (action (chdir ../../.. (run %{update_suite} group affeq -q))))
diff --git a/tests/regression/77-lin2vareq/dune b/tests/regression/77-lin2vareq/dune
index b4cede7223..bfbf6e4438 100644
--- a/tests/regression/77-lin2vareq/dune
+++ b/tests/regression/77-lin2vareq/dune
@@ -7,4 +7,4 @@
    (:update_suite ../../../scripts/update_suite.rb)
    (glob_files ??-*.c))
  (locks /update_suite)
- (action (chdir ../../.. (run %{update_suite} group lin2vareq))))
\ No newline at end of file
+ (action (chdir ../../.. (run %{update_suite} group lin2vareq -q))))
\ No newline at end of file
diff --git a/tests/regression/78-termination/dune b/tests/regression/78-termination/dune
index b724966cf7..a94c39def4 100644
--- a/tests/regression/78-termination/dune
+++ b/tests/regression/78-termination/dune
@@ -7,4 +7,4 @@
    (:update_suite ../../../scripts/update_suite.rb)
    (glob_files ??-*.c))
  (locks /update_suite)
- (action (chdir ../../.. (run %{update_suite} group termination))))
+ (action (chdir ../../.. (run %{update_suite} group termination -q))))
diff --git a/tests/regression/dune b/tests/regression/dune
index 7ff91483c6..8f550d190e 100644
--- a/tests/regression/dune
+++ b/tests/regression/dune
@@ -17,7 +17,7 @@
    (glob_files_rec 56-witness/??-*.yml) ; excluding witness.yml, etc. which might exist due to running update_suite outside of dune
    (source_tree ../../linux-headers))
  (locks /update_suite)
- (action (chdir ../.. (run %{update_suite}))))
+ (action (chdir ../.. (run %{update_suite} -q))))
 
 (cram
  (applies_to :whole_subtree)