Remove dx9 #124
Merged
Remove dx9 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't build against the current FFXIVQuickLauncher master. I think you didn't update the submodule before testing. Currently getting this error: |
|
She made this before I made my changes that remove DX9, you should just need to remove the argument - was the only thing that needed changing. |
|
Should build again now |
|
Awesome. Was just trying to update the compatibility rework patches to work with latest, and the remove dx9 bit was causing issues. |
marzent
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all dx9 components from XLCore
There are still some parts of XLCommon that need removing and will need updating in this PR.