diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 1e0515d0..7a53e50c 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -5,12 +5,14 @@ name: reviewdog on: pull_request: +# NOTE: We have to specify `go_version: 1.17` because the action was installing 1.18. +# 1.18, in turn, is not fully supported by golangci-lint yet, and it can fail silently: +# see: https://github.com/reviewdog/action-golangci-lint/issues/249 + # pipeline to execute jobs: diff-review: runs-on: ubuntu-latest - container: - image: golang:1.17 steps: - name: clone uses: actions/checkout@v3 @@ -19,15 +21,14 @@ jobs: uses: reviewdog/action-golangci-lint@v2 with: github_token: ${{ secrets.github_token }} - golangci_lint_flags: "--config=.golangci.yml" + go_version: 1.17.9 + golangci_lint_flags: "--config=.golangci.yml --verbose" fail_on_error: true filter_mode: diff_context reporter: github-pr-review full-review: runs-on: ubuntu-latest - container: - image: golang:1.17 steps: - name: clone uses: actions/checkout@v3 @@ -36,6 +37,7 @@ jobs: uses: reviewdog/action-golangci-lint@v2 with: github_token: ${{ secrets.github_token }} - golangci_lint_flags: "--config=.golangci.yml" + go_version: 1.17.9 + golangci_lint_flags: "--config=.golangci.yml --verbose" fail_on_error: false filter_mode: nofilter