Using glob curly braces expansion in sources prevents change detection for some files

[Neonox31]

Description

Hello,

First thanks a lot for all your work on this project, I use it often for personal and professional contexts and saves me a lot of trouble 👍

Using :

sources:
  - src/{api,ingest-worker}/**/*

triggers correctly the job if I change source files in src/api folder but never trigger the job if I change files inside src/ingest-worker.
Instead the following :

sources:
  - src/api/**/*
  - src/ingest-worker/**/*

triggers the job if I change files inside both src/api and src/ingest-worker folders.

To be sure, I checked my syntax with zglob and seems to be OK :

❯ /bin/find dist/ src/
dist/
dist/ingest-worker
dist/ingest-worker/ingest-worker.out
dist/api
dist/api/api.out
src/
src/ingest-worker
src/ingest-worker/ingest-worker.source
src/foo
src/foo/foo.source
src/api
src/api/api.source

❯ ./zglob -d 'src/{api,ingest-worker}/**/*'
src/ingest-worker/ingest-worker.source
src/api/api.source

Maybe I misunderstood something but both methods should not match same files here ?

Version

Task version: v3.41.0 (h1:giUddhe0XZLbEWIQ/MuTPipR9ek+teulIA5xf/2IHXg=)

Operating system

Linux

Experiments Enabled

No response

Example Taskfile

version: '3'

tasks:
  build:
    cmds:
      - mkdir -p dist/{api,ingest-worker}
      - cp src/api/api.source dist/api/api.out
      - cp src/ingest-worker/ingest-worker.source dist/ingest-worker/ingest-worker.out
    sources:
      - src/{api,ingest-worker}/**/*

[pd93]

Thanks for filing this and providing a detailed example. I am able to reproduce your issue.

As you said, this is not the fault of zglob. If you pass src/{api,ingest-worker}/**/* into zglob it will give the expected result. This issue is being caused by us preprocessing the string using execext.Expand. This then calls into the mvdan shell.Fields function which will perform the brace expansion and return a list of matching files. However, currently we are only returning the first match which means that by the time the string gets to zglob, any references to the second directory are gone.

Interestingly, shell.Fields actually calls into expand.Fields which then accepts a cfg object. In this config, you can enable globbing and globstar. So maybe we don't need zglob at all!

I've created a draft PR (#2075) for this, but I need to look into whether moving from zglob to mvdan's globbing has any other knock-on effects. I also want to check if we can avoid calling Expand in other places. For now, I have replaced any other calls to Expand with ExpandFirst which is a wrapper that will just return the first result (like we do now).