Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Re-add sprout.FuncMap #49

Open
1 task done
andig opened this issue Aug 16, 2024 · 2 comments
Open
1 task done

proposal: Re-add sprout.FuncMap #49

andig opened this issue Aug 16, 2024 · 2 comments
Assignees
Labels
type/chore 🛠 Code changes that neither fix bugs nor add features (refactoring, dependency changes, ...)

Comments

@andig
Copy link

andig commented Aug 16, 2024

You have a proposal, explain it!

0.5 adds a breaking change by removing/replacing sprout.FuncMap

Describe the solution you'd like

It doesn't seem necessary to do so. Instead of forcing devs to update packages, sprout.FuncMap could remain providing the same functionality as before.

Additional context

I don't care for template performance at all ;)

Code of Conduct

  • I agree to follow this project's Code of Conduct
@andig andig added the state/triage 🚦 Has not been triaged & therefore, not ready for work label Aug 16, 2024
@42atomys
Copy link
Member

Hello @andig,

Due to the way Go modules are structured, it's not possible to mix "all-in-one package" builds with "per package" builds. The "all-in-one" build method imports all dependencies simultaneously, which can lead to dependency management issues. These issues are typically addressed by using a registry system, which handles dependencies more efficiently and avoids potential conflicts.

To help developers transition smoothly without needing to adopt the new system immediately, a sprigin package has been made available and is explained in detail here: Transitioning from Sprig.

P.S. For your project, evcc, I have forked the project to implement the update. The PR will be available today or tomorrow. :)

@42atomys 42atomys added type/chore 🛠 Code changes that neither fix bugs nor add features (refactoring, dependency changes, ...) and removed state/triage 🚦 Has not been triaged & therefore, not ready for work labels Aug 16, 2024
@andig
Copy link
Author

andig commented Aug 18, 2024

Upgrade is done ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore 🛠 Code changes that neither fix bugs nor add features (refactoring, dependency changes, ...)
Projects
None yet
Development

No branches or pull requests

2 participants