Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In order for SVG Partials to work properly, it is required to use a deprecated SVG attribute. #61

Open
roblabs opened this issue Jun 26, 2019 · 3 comments
Labels
documention Issues outlining Gotcha/work arounds/etc.. that need to go into the wiki

Comments

@roblabs
Copy link
Collaborator

roblabs commented Jun 26, 2019

In order for SVG Partials to work properly, it is required to use a deprecated SVG attribute.

File under Won't Fix or known issue

According to https://developer.mozilla.org/en-US/docs/Web/SVG/Element/use#Attributes
the attribute href should be used when including another SVG within a template.

But for atlante to work, the Deprecated attribute xlink:href MUST be used.

Issue is likely related to the SVG to PDF code.

Example,

This works, but use the deprecated SVG attribute xlink:href

<use x="366" y="1430" xlink:href="assets/partial1.svg#Layer_1" />

The expected attribute href does not work

<use x="366" y="1430" href="assets/partial1.svg#Layer_1" />
@gdey
Copy link
Member

gdey commented Jun 27, 2019

The library we are using currently only supports xlink:href

@gdey gdey added the documention Issues outlining Gotcha/work arounds/etc.. that need to go into the wiki label Jul 18, 2019
@jj0hns0n
Copy link

Closing as #wontfix

@gdey
Copy link
Member

gdey commented Jul 19, 2019

The ones labeled documentation are so that we can add them to the wiki to create a knowledge base. This issue is not more to let others know; that they can not remove the xlink:ref property.

@gdey gdey reopened this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documention Issues outlining Gotcha/work arounds/etc.. that need to go into the wiki
Projects
None yet
Development

No branches or pull requests

3 participants