fix: Fixed NULL not being formatted for slices/maps.
#1930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a query parameter was a nil slice or a nil map, the value `NULL` would not be appended to the query. Instead `'null'` would be appended to the query which is not correct. Resolves go-pg#1908
vmihailenco
reviewed
Nov 21, 2021
| // value. | ||
| if v.IsNil() { | ||
| return AppendNull(b, flags) | ||
| } | ||
| } | ||
| appender := Appender(v.Type()) |
There was a problem hiding this comment.
The idea is that you should be able to call Appender once for a type and then use it to append different values of the given type (nil or non-nil). So the function returned by appender should handle nil values, not appendValue itself.
I guess it is not worth fixing this properly so let's keep this code, but at least we should have an end-to-end test that inserts and selects slice/map from a real table...
vmihailenco
force-pushed
the
v10
branch
3 times, most recently
from
8925177
to
49ebb57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a query parameter was a nil slice or a nil map, the value
NULLwould not be appended to the query. Instead
'null'would be appendedto the query which is not correct.
Resolves #1908