refactor the test that checks the mutation run in the correct folder #172
alessio-perugini
started this conversation in
Development
Replies: 1 comment 5 replies
-
I was thinking to do, more or less, the same, but I didn't want to bother you with too much changes in the PR :) Not sure if we need all the changes in the dealerStub, maybe we can postpone when we actually need them. |
Beta Was this translation helpful? Give feedback.
5 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In #171 I proposed a version of the test that I think adds up unneeded complexity.
You can find an alternative here: https://github.com/alessio-perugini/gremlins/pull/1/files
Adding the cmd directly to
commandHolder
and checking the Dir value, which will be changed by the actual implementation, feels more right to me.If we choose to implement the proposed version that you can find in the link above, we might want to remove the changes I made to the
dealerStub
. (Even though retaining the map in thedealerStub
may become handy in the future)Beta Was this translation helpful? Give feedback.
All reactions